Skip to content

Rails 6.1 support #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Piioo opened this issue Jan 13, 2021 · 8 comments
Closed

Rails 6.1 support #170

Piioo opened this issue Jan 13, 2021 · 8 comments

Comments

@Piioo
Copy link

Piioo commented Jan 13, 2021

Hello,

Rails 6.1 has been out for a few weeks now.

When can we expect an update of the cockroachdb adapter?
Without this we cant update our applications to Rais 6.1.

Thank you

@vy-ton
Copy link

vy-ton commented Jan 22, 2021

@Piioo Our team is taking a look, we should have an update in a few weeks.

@vy-ton
Copy link

vy-ton commented Feb 11, 2021

@Piioo CockroachDB’s Active Record adapter v6.1.0beta1 now includes beta support for Rails 6.1. Please try it out and report any issues.

@carlallen
Copy link
Contributor

Using 6.1.0.pre.beta.3, decimals are being cast to integers.

@vy-ton
Copy link

vy-ton commented Apr 26, 2021

@keithdoggett Can you take a look at the decimal to integer cast issue?

@keithdoggett
Copy link
Contributor

@vy-ton, @carlallen opened #197 which fixes the issue. I've given it a look and it should be good, but we should get someone else to review it as well.

@Piioo
Copy link
Author

Piioo commented Apr 28, 2021

Thanks @vy-ton it seams to work. I have not checked the cast, only the update for our purpose

@emmahsax
Copy link

@Piioo It looks like as of 2021-04-26 the master branch is officially Rails 6.1 compatible. The release is not out yet though. But if you could pull straight from the master branch, maybe you could get the update.

@rafiss
Copy link
Contributor

rafiss commented Apr 30, 2021

@emmahsax We also published the release on rubygems earlier this week: https://rubygems.org/gems/activerecord-cockroachdb-adapter/versions/

I just created a release on Github as well. I'll close this issue, and the fix from #197 should be released later.

Thanks for your patience for Rails 6.1 support everyone!

@rafiss rafiss closed this as completed Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants