Update golangci lint version

Author: prafull01

Diff for: hack/bin/deps.bzl

@@ -142,8 +142,8 @@ def install_integration_test_dependencies():
     http_file(
         name = "kube-apiserver_linux_amd64",
         executable = 1,
-        sha256 = "b4505b838b27b170531afbdef5e7bfaacf83da665f21b0e3269d1775b0defb7a",
-        urls = ["https://storage.googleapis.com/kubernetes-release/release/v1.17.3/bin/linux/amd64/kube-apiserver"],
+        sha256 = "a70a704835450130f8feeac9d42617d527e269c25a5aa92590e54533c2d4f776",
+        urls = ["https://storage.googleapis.com/cockroach-operator-testing-assets/kube-apiserver-1.24.2_linux_amd64"],
     )
 
     http_archive(
@@ -220,14 +220,14 @@ def install_k3d():
 def install_golangci_lint():
     http_archive(
         name = "golangci_lint_darwin",
-        sha256 = "15c4d19a2c85a04f67779047dbb9467ba176c71fff762a0d514a21bb75e4b42c",
-        urls = ["https://github.com/golangci/golangci-lint/releases/download/v1.56.2/golangci-lint-1.56.2-darwin-amd64.tar.gz"],
+        sha256 = "5c280ef3284f80c54fd90d73dc39ca276953949da1db03eb9dd0fbf868cc6e55",
+        urls = ["https://github.com/golangci/golangci-lint/releases/download/v1.61.0/golangci-lint-1.61.0-darwin-amd64.tar.gz"],
         build_file_content =
          """
 filegroup(
      name = "file",
      srcs = [
-        "golangci-lint-1.56.2-darwin-amd64/golangci-lint",
+        "golangci-lint-1.61.0-darwin-amd64/golangci-lint",
      ],
      visibility = ["//visibility:public"],
 )
@@ -236,14 +236,14 @@ filegroup(
 
     http_archive(
             name = "golangci_lint_m1",
-            sha256 = "5f9ecda712c7ae08fbf872336fae3db866720e5865903d4c53903184b2a2c2dc",
-            urls = ["https://github.com/golangci/golangci-lint/releases/download/v1.56.2/golangci-lint-1.56.2-darwin-arm64.tar.gz"],
+            sha256 = "544334890701e4e04a6e574bc010bea8945205c08c44cced73745a6378012d36",
+            urls = ["https://github.com/golangci/golangci-lint/releases/download/v1.61.0/golangci-lint-1.61.0-darwin-arm64.tar.gz"],
             build_file_content =
              """
 filegroup(
     name = "file",
     srcs = [
-       "golangci-lint-1.56.2-darwin-arm64/golangci-lint",
+       "golangci-lint-1.61.0-darwin-arm64/golangci-lint",
     ],
     visibility = ["//visibility:public"],
 )
@@ -252,14 +252,14 @@ filegroup(
 
     http_archive(
         name = "golangci_lint_linux",
-        sha256 = "e1c313fb5fc85a33890fdee5dbb1777d1f5829c84d655a47a55688f3aad5e501",
-        urls = ["https://github.com/golangci/golangci-lint/releases/download/v1.56.2/golangci-lint-1.56.2-linux-amd64.tar.gz"],
+        sha256 = "77cb0af99379d9a21d5dc8c38364d060e864a01bd2f3e30b5e8cc550c3a54111",
+        urls = ["https://github.com/golangci/golangci-lint/releases/download/v1.61.0/golangci-lint-1.61.0-linux-amd64.tar.gz"],
         build_file_content =
          """
 filegroup(
      name = "file",
      srcs = [
-        "golangci-lint-1.56.2-linux-amd64/golangci-lint",
+        "golangci-lint-1.61.0-linux-amd64/golangci-lint",
      ],
      visibility = ["//visibility:public"],
 )

Diff for: pkg/resource/statefulset.go

@@ -232,7 +232,7 @@ func (b StatefulSetBuilder) makePodTemplate() corev1.PodTemplateSpec {
 		pod.Spec.TopologySpreadConstraints = b.Spec().TopologySpreadConstraints
 	}
 
-	if b.Spec().NodeSelector != nil && len(b.Spec().NodeSelector) > 0 {
+	if len(b.Spec().NodeSelector) > 0 {
 		pod.Spec.NodeSelector = b.Spec().NodeSelector
 	}
 

Diff for: pkg/testutil/require.go

@@ -660,7 +660,7 @@ func RequireClusterInFailedState(t *testing.T, sb testenv.DiffingSandbox, b Clus
 		},
 	}
 
-	wErr := wait.Poll(10*time.Second, 2*time.Minute, func() (bool, error) {
+	wErr := wait.Poll(10*time.Second, 5*time.Minute, func() (bool, error) {
 		if err := sb.Get(&crdbCluster); err != nil {
 			return false, err
 		}
@@ -672,6 +672,7 @@ func RequireClusterInFailedState(t *testing.T, sb testenv.DiffingSandbox, b Clus
 		return false, nil
 	})
 
+	t.Logf("CRDB Cluster status: %s", crdbCluster.Status.ClusterStatus)
 	require.NoError(t, wErr)
 }