Skip to content

Commit 038ffe7

Browse files
craig[bot]renatolabsjayshrivastavaerikgrinakermgartner
committed
118324: roachtest: introduce `registry.ErrorWithOwner` r=srosenberg a=renatolabs This function allows the caller to assign ownership directly when creating an error, which is very useful when we know that a failure during a certain part of the test should always be investigated by a certain team (for instance, if a test fails during setup, Test Eng should investigate, as the owners of the test infrastructure). Epic: none Release note: None 118598: changefeedccl: implement simple pulsar sink r=jayshrivastava a=jayshrivastava ### changefeedccl: install apache pulsar library This change adds the pulsar go client dependency https://github.com/apache/pulsar-client-go. Release note: None Epic: https://cockroachlabs.atlassian.net/browse/CRDB-9180 --- ### changefeedccl: implement simple pulsar sink This change adds a simple pulsar sink implementation to changefeeds and integrates it with unit tests. The pulsar sink implementation supports - json and csv format The sink does not support: - several changefeed options (resolved, updated, mvcc, topic_prefix, etc.) - avro format - schema registry - batching configuration - authentication methods - external connections Nor does it have roachtests for correctness testing and auth testing. We also need to audit the metrics updated by the sink, ensuring that none are missed. These issues will be addressed later as a part of the epic below. Epic: https://cockroachlabs.atlassian.net/browse/CRDB-9180 Closes: #118854 Release note: None --- ### do not merge: force pulsar sink in unit tests when possible This change forces CI to run with the pular sink when a random sink option is available. This change will be reverted before merging. Release note: None Epic: None 118726: storage: add `MVCCIncrementalIterIntentPolicyIgnore` r=erikgrinaker a=erikgrinaker This allows callers that have already scanned the lock table to disable intent interleaving for a minor performance improvement. The policy is adopted in `MVCCClearTimeRange` and `MVCCDeleteRangeUsingTombstone`, which already do such lock table scans. Touches #113116. Epic: none Release note: None 118910: opt/execbuilder: fix buggy allocation of result columns r=mgartner a=mgartner This commit fixes a subtle bug where a slice was always allocated with zero capacity, rather than the known required capacity. This bug caused no user facing issues, but did cause extra allocations when appending to the slice. Informs #117546 Release note: None Co-authored-by: Renato Costa <[email protected]> Co-authored-by: Jayant Shrivastava <[email protected]> Co-authored-by: Erik Grinaker <[email protected]> Co-authored-by: Marcus Gartner <[email protected]>
5 parents bf84f8d + b5e01fc + 55c5b54 + 9cdb25f + cb1eed7 commit 038ffe7

File tree

23 files changed

+1153
-202
lines changed

23 files changed

+1153
-202
lines changed

DEPS.bzl

Lines changed: 147 additions & 27 deletions
Large diffs are not rendered by default.

build/bazelutil/distdir_files.bzl

Lines changed: 21 additions & 9 deletions
Large diffs are not rendered by default.

go.mod

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ require (
105105
github.com/andygrunwald/go-jira v1.14.0
106106
github.com/apache/arrow/go/arrow v0.0.0-20200923215132-ac86123a3f01
107107
github.com/apache/arrow/go/v11 v11.0.0
108+
github.com/apache/pulsar-client-go v0.12.0
108109
github.com/aws/aws-sdk-go-v2/service/secretsmanager v1.18.2
109110
github.com/axiomhq/hyperloglog v0.0.0-20181223111420-4b99d0c2c99e
110111
github.com/bazelbuild/rules_go v0.26.0
@@ -217,7 +218,7 @@ require (
217218
github.com/slack-go/slack v0.9.5
218219
github.com/snowflakedb/gosnowflake v1.3.4
219220
github.com/spf13/afero v1.9.2
220-
github.com/spf13/cobra v1.2.1
221+
github.com/spf13/cobra v1.6.1
221222
github.com/spf13/pflag v1.0.5
222223
github.com/stretchr/testify v1.8.4
223224
github.com/twpayne/go-geom v1.4.2
@@ -248,6 +249,9 @@ require (
248249
cloud.google.com/go/compute/metadata v0.2.3 // indirect
249250
cloud.google.com/go/iam v0.12.0 // indirect
250251
cloud.google.com/go/longrunning v0.4.1 // indirect
252+
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
253+
github.com/99designs/keyring v1.2.1 // indirect
254+
github.com/AthenZ/athenz v1.10.39 // indirect
251255
github.com/Azure/azure-sdk-for-go/sdk/internal v1.1.1 // indirect
252256
github.com/Azure/azure-sdk-for-go/sdk/keyvault/internal v0.7.0 // indirect
253257
github.com/Azure/go-ansiterm v0.0.0-20210617225240-d185dfc1b5a1 // indirect
@@ -269,21 +273,25 @@ require (
269273
github.com/alexbrainman/sspi v0.0.0-20210105120005-909beea2cc74 // indirect
270274
github.com/andybalholm/brotli v1.0.5 // indirect
271275
github.com/apache/thrift v0.16.0 // indirect
276+
github.com/ardielle/ardielle-go v1.5.2 // indirect
272277
github.com/asaskevich/govalidator v0.0.0-20200907205600-7a23bdc65eef // indirect
273278
github.com/atotto/clipboard v0.1.4 // indirect
274279
github.com/aws/smithy-go v1.13.5 // indirect
275280
github.com/aymanbagabas/go-osc52 v1.0.3 // indirect
276281
github.com/beorn7/perks v1.0.1 // indirect
277282
github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d // indirect
283+
github.com/bits-and-blooms/bitset v1.4.0 // indirect
278284
github.com/cenkalti/backoff/v4 v4.1.3 // indirect
279285
github.com/cespare/xxhash/v2 v2.2.0 // indirect
280286
github.com/charmbracelet/bubbletea v0.23.1 // indirect
281287
github.com/charmbracelet/lipgloss v0.6.0 // indirect
288+
github.com/danieljoos/wincred v1.1.2 // indirect
282289
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.1.0 // indirect
283290
github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect
284291
github.com/dimchansky/utfbom v1.1.1 // indirect
285292
github.com/djherbis/atime v1.1.0 // indirect
286293
github.com/docker/go-units v0.4.0 // indirect
294+
github.com/dvsekhvalnov/jose2go v1.6.0 // indirect
287295
github.com/eapache/go-resiliency v1.4.0 // indirect
288296
github.com/eapache/go-xerial-snappy v0.0.0-20230731223053-c322873962e3 // indirect
289297
github.com/eapache/queue v1.1.0 // indirect
@@ -307,6 +315,7 @@ require (
307315
github.com/go-openapi/validate v0.20.2 // indirect
308316
github.com/go-stack/stack v1.8.0 // indirect
309317
github.com/goccy/go-json v0.9.11 // indirect
318+
github.com/godbus/dbus v0.0.0-20190726142602-4481cbc300e2 // indirect
310319
github.com/gofrs/flock v0.8.1 // indirect
311320
github.com/gofrs/uuid v4.0.0+incompatible // indirect
312321
github.com/golang-jwt/jwt v3.2.2+incompatible // indirect
@@ -317,14 +326,15 @@ require (
317326
github.com/gorilla/handlers v1.5.1 // indirect
318327
github.com/gorilla/websocket v1.4.2 // indirect
319328
github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 // indirect
329+
github.com/gsterjov/go-libsecret v0.0.0-20161001094733-a6f4afe4910c // indirect
320330
github.com/hashicorp/errwrap v1.1.0 // indirect
321331
github.com/hashicorp/go-multierror v1.1.1 // indirect
322332
github.com/hashicorp/go-uuid v1.0.3 // indirect
323333
github.com/hashicorp/hcl v1.0.0 // indirect
324334
github.com/huandu/xstrings v1.3.0 // indirect
325335
github.com/ianlancetaylor/demangle v0.0.0-20200824232613-28f6c0f3b639 // indirect
326336
github.com/imdario/mergo v0.3.13 // indirect
327-
github.com/inconshreveable/mousetrap v1.0.0 // indirect
337+
github.com/inconshreveable/mousetrap v1.0.1 // indirect
328338
github.com/jackc/puddle/v2 v2.2.0 // indirect
329339
github.com/jcmturner/aescts/v2 v2.0.0 // indirect
330340
github.com/jcmturner/dnsutils/v2 v2.0.0 // indirect
@@ -365,12 +375,14 @@ require (
365375
github.com/morikuni/aec v1.0.0 // indirect
366376
github.com/mostynb/go-grpc-compression v1.1.12 // indirect
367377
github.com/mozillazg/go-unidecode v0.2.0 // indirect
378+
github.com/mtibben/percent v0.2.1 // indirect
368379
github.com/muesli/termenv v0.13.0 // indirect
369380
github.com/mwitkow/go-proto-validators v0.0.0-20180403085117-0950a7990007 // indirect
370381
github.com/oklog/ulid v1.3.1 // indirect
371382
github.com/opencontainers/go-digest v1.0.0 // indirect
372383
github.com/openzipkin/zipkin-go v0.2.5 // indirect
373384
github.com/pelletier/go-toml v1.9.5 // indirect
385+
github.com/pierrec/lz4 v2.5.2+incompatible // indirect
374386
github.com/pkg/profile v1.6.0 // indirect
375387
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c // indirect
376388
github.com/pquerna/cachecontrol v0.0.0-20200921180117-858c6e7e6b7e // indirect
@@ -383,6 +395,7 @@ require (
383395
github.com/sahilm/fuzzy v0.1.0 // indirect
384396
github.com/sirupsen/logrus v1.9.0 // indirect
385397
github.com/slok/go-http-metrics v0.10.0 // indirect
398+
github.com/spaolacci/murmur3 v1.1.0 // indirect
386399
github.com/spf13/cast v1.3.1 // indirect
387400
github.com/spf13/jwalterweatherman v1.1.0 // indirect
388401
github.com/spf13/viper v1.8.1 // indirect
@@ -415,7 +428,7 @@ require (
415428
github.com/DataDog/zstd v1.5.0 // indirect
416429
github.com/andybalholm/cascadia v1.2.0 // indirect
417430
github.com/containerd/console v1.0.3 // indirect
418-
github.com/cpuguy83/go-md2man/v2 v2.0.1 // indirect
431+
github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect
419432
github.com/dgryski/go-metro v0.0.0-20180109044635-280f6062b5bc // indirect
420433
github.com/envoyproxy/protoc-gen-validate v0.9.1 // indirect
421434
github.com/golang/glog v1.0.0 // indirect

0 commit comments

Comments
 (0)