Skip to content

Commit 341cc51

Browse files
craig[bot]herkolategan
andcommitted
Merge #130012
130012: roachprod-microbench: pass influx env vars r=DarrylWong a=herkolategan In order to start publishing the results to InfluxDB 'automatically' we need to pass the args to the `compare` command. Epic: None Release note: None Co-authored-by: Herko Lategan <[email protected]>
2 parents 00edd9c + 3e2b95b commit 341cc51

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

build/teamcity/cockroach/nightlies/microbenchmark_weekly.sh

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
# BENCH_IGNORE_PACKAGES: comma-separated list of packages to exclude completely from listing and execution (default: none)
2020
# TEST_ARGS: additional arguments to pass to the test binary (default: none)
2121
# MICROBENCH_SLACK_TOKEN: token to use to post to slack (default: none)
22+
# MICROBENCH_INFLUX_HOST: Influx host path to use to push results to InfluxDB (default: none)
23+
# MICROBENCH_INFLUX_TOKEN: auth token to use to push results to InfluxDB (default: none)
2224

2325
set -exuo pipefail
2426

@@ -163,12 +165,17 @@ if [ -d "$output_dir/experiment" ] && [ "$(ls -A "$output_dir/experiment")" ] \
163165
# Set up slack token only if the build was triggered by TeamCity (not a manual run)
164166
if [ -n "${TRIGGERED_BUILD:-}" ]; then
165167
slack_token="${MICROBENCH_SLACK_TOKEN}"
168+
influx_token="${MICROBENCH_INFLUX_TOKEN}"
169+
influx_host="${MICROBENCH_INFLUX_HOST}"
166170
fi
167171
# Sheet description is in the form: `baseline` to `experiment`
168172
sheet_description="${name_arr[1]} -> ${name_arr[0]}"
169173
./bin/roachprod-microbench compare "$output_dir/experiment" "$output_dir/baseline" \
170174
${slack_token:+--slack-token="$slack_token"} \
171-
--sheet-desc="$sheet_description" 2>&1 | tee "$output_dir/sheets.txt"
175+
--sheet-desc="$sheet_description" \
176+
${influx_token:+--influx-token="$influx_token"} \
177+
${influx_host:+--influx-host="$influx_host"} \
178+
2>&1 | tee "$output_dir/sheets.txt"
172179
else
173180
echo "No microbenchmarks were run. Skipping comparison."
174181
fi

0 commit comments

Comments
 (0)