Skip to content

Commit 8e724de

Browse files
committed
roachtest/perturbation: disable low mem config for restart and partition tests
Informs #137666. This commit disables the low memory configuration for the `restart` and `partition` tests in the `perturbation` roaachtest suite. These tests can trigger range snapshots, which can overwhelm the low memory configuration and cause it to OOM. Release note: None
1 parent a31affb commit 8e724de

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

pkg/cmd/roachtest/tests/perturbation/network_partition.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster"
1616
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/option"
1717
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/registry"
18+
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/spec"
1819
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test"
1920
"github.com/cockroachdb/cockroach/pkg/roachprod/install"
2021
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
@@ -42,7 +43,13 @@ func (p partition) setupMetamorphic(rng *rand.Rand) variations {
4243
v := p.setup()
4344
p.partitionSite = rng.Intn(2) == 0
4445
v.perturbation = p
45-
return v.randomize(rng)
46+
v = v.randomize(rng)
47+
// TODO(#137666): The partition test can cause OOM with low memory
48+
// configurations.
49+
if v.mem == spec.Low {
50+
v.mem = spec.Standard
51+
}
52+
return v
4653
}
4754

4855
func (p partition) startTargetNode(ctx context.Context, t test.Test, v variations) {

pkg/cmd/roachtest/tests/perturbation/restart_node.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import (
1212
"time"
1313

1414
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/option"
15+
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/spec"
1516
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test"
1617
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
1718
)
@@ -47,6 +48,11 @@ func (r restart) setupMetamorphic(rng *rand.Rand) variations {
4748
r.cleanRestart = rng.Intn(2) == 0
4849
v.perturbation = r
4950
v = v.randomize(rng)
51+
// TODO(#137666): The restart test can cause OOM with low memory
52+
// configurations.
53+
if v.mem == spec.Low {
54+
v.mem = spec.Standard
55+
}
5056
return v
5157
}
5258

0 commit comments

Comments
 (0)