replica_rac2: fix unprotected RangeController ref

pav-kv · pav-kv · commit ae3a9e0cb5f0 · 2024-09-10T05:10:34.000+01:00
The p.mu.leader.rc field can not be accessed without holding one of the
mutexes protecting it. Use the cached rd variable.

Epic: none
Release note: none
diff --git a/pkg/kv/kvserver/kvflowcontrol/replica_rac2/processor.go b/pkg/kv/kvserver/kvflowcontrol/replica_rac2/processor.go
@@ -988,7 +988,7 @@ func (p *processorImpl) AdmitForEval(
 		p.opts.EvalWaitMetrics.OnBypassed(workClass, 0 /* duration */)
 		return false, nil
 	}
-	return p.mu.leader.rc.WaitForEval(ctx, pri)
+	return rc.WaitForEval(ctx, pri)
 }
 
 func admittedIncreased(prev, next [raftpb.NumPriorities]uint64) bool {

Original file line number	Diff line number	Diff line change
`@@ -988,7 +988,7 @@ func (p *processorImpl) AdmitForEval(`
`988`	`988`	`p.opts.EvalWaitMetrics.OnBypassed(workClass, 0 /* duration */)`
`989`	`989`	`return false, nil`
`990`	`990`	`}`
`991`		`- return p.mu.leader.rc.WaitForEval(ctx, pri)`
	`991`	`+ return rc.WaitForEval(ctx, pri)`
`992`	`992`	`}`
`993`	`993`
`994`	`994`	`func admittedIncreased(prev, next [raftpb.NumPriorities]uint64) bool {`