Skip to content

Commit c6956d5

Browse files
craig[bot]rharding6373
andcommitted
Merge #129946
129946: changefeedccl: update changefeed.sink_io_workers description r=wenyihu6 a=rharding6373 Include pubsub and kafka v2 in supported sinks. Epic: CRDB-41784 Fixes: #127362 Release note (enterprise change): Updates the cluster setting `changefeed.sink_io_workers` with all the sinks that support the setting. Co-authored-by: rharding6373 <[email protected]>
2 parents fd00996 + 900da13 commit c6956d5

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

docs/generated/settings/settings-for-tenants.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ changefeed.node_throttle_config string specifies node level throttling configur
2424
changefeed.protect_timestamp.max_age duration 96h0m0s fail the changefeed if the protected timestamp age exceeds this threshold; 0 disables expiration application
2525
changefeed.protect_timestamp_interval duration 10m0s controls how often the changefeed forwards its protected timestamp to the resolved timestamp application
2626
changefeed.schema_feed.read_with_priority_after duration 1m0s retry with high priority if we were not able to read descriptors for too long; 0 disables application
27-
changefeed.sink_io_workers integer 0 the number of workers used by changefeeds when sending requests to the sink (currently webhook only): <0 disables, 0 assigns a reasonable default, >0 assigns the setting value application
27+
changefeed.sink_io_workers integer 0 the number of workers used by changefeeds when sending requests to the sink (currently the batching versions of webhook, pubsub, and kafka sinks that are enabled by changefeed.new_<sink type>_sink_enabled only): <0 disables, 0 assigns a reasonable default, >0 assigns the setting value application
2828
cloudstorage.azure.concurrent_upload_buffers integer 1 controls the number of concurrent buffers that will be used by the Azure client when uploading chunks.Each buffer can buffer up to cloudstorage.write_chunk.size of memory during an upload application
2929
cloudstorage.azure.read.node_burst_limit byte size 0 B burst limit on number of bytes per second per node across operations writing to the designated cloud storage provider if non-zero application
3030
cloudstorage.azure.read.node_rate_limit byte size 0 B limit on number of bytes per second per node across operations writing to the designated cloud storage provider if non-zero application

docs/generated/settings/settings.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
<tr><td><div id="setting-changefeed-protect-timestamp-max-age" class="anchored"><code>changefeed.protect_timestamp.max_age</code></div></td><td>duration</td><td><code>96h0m0s</code></td><td>fail the changefeed if the protected timestamp age exceeds this threshold; 0 disables expiration</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
3030
<tr><td><div id="setting-changefeed-protect-timestamp-interval" class="anchored"><code>changefeed.protect_timestamp_interval</code></div></td><td>duration</td><td><code>10m0s</code></td><td>controls how often the changefeed forwards its protected timestamp to the resolved timestamp</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
3131
<tr><td><div id="setting-changefeed-schema-feed-read-with-priority-after" class="anchored"><code>changefeed.schema_feed.read_with_priority_after</code></div></td><td>duration</td><td><code>1m0s</code></td><td>retry with high priority if we were not able to read descriptors for too long; 0 disables</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
32-
<tr><td><div id="setting-changefeed-sink-io-workers" class="anchored"><code>changefeed.sink_io_workers</code></div></td><td>integer</td><td><code>0</code></td><td>the number of workers used by changefeeds when sending requests to the sink (currently webhook only): &lt;0 disables, 0 assigns a reasonable default, &gt;0 assigns the setting value</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
32+
<tr><td><div id="setting-changefeed-sink-io-workers" class="anchored"><code>changefeed.sink_io_workers</code></div></td><td>integer</td><td><code>0</code></td><td>the number of workers used by changefeeds when sending requests to the sink (currently the batching versions of webhook, pubsub, and kafka sinks that are enabled by changefeed.new_&lt;sink type&gt;_sink_enabled only): &lt;0 disables, 0 assigns a reasonable default, &gt;0 assigns the setting value</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
3333
<tr><td><div id="setting-cloudstorage-azure-concurrent-upload-buffers" class="anchored"><code>cloudstorage.azure.concurrent_upload_buffers</code></div></td><td>integer</td><td><code>1</code></td><td>controls the number of concurrent buffers that will be used by the Azure client when uploading chunks.Each buffer can buffer up to cloudstorage.write_chunk.size of memory during an upload</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
3434
<tr><td><div id="setting-cloudstorage-azure-read-node-burst-limit" class="anchored"><code>cloudstorage.azure.read.node_burst_limit</code></div></td><td>byte size</td><td><code>0 B</code></td><td>burst limit on number of bytes per second per node across operations writing to the designated cloud storage provider if non-zero</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
3535
<tr><td><div id="setting-cloudstorage-azure-read-node-rate-limit" class="anchored"><code>cloudstorage.azure.read.node_rate_limit</code></div></td><td>byte size</td><td><code>0 B</code></td><td>limit on number of bytes per second per node across operations writing to the designated cloud storage provider if non-zero</td><td>Serverless/Dedicated/Self-Hosted</td></tr>

pkg/ccl/changefeedccl/changefeedbase/settings.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,9 @@ var SinkIOWorkers = settings.RegisterIntSetting(
291291
settings.ApplicationLevel,
292292
"changefeed.sink_io_workers",
293293
"the number of workers used by changefeeds when sending requests to the sink "+
294-
"(currently webhook only): <0 disables, 0 assigns a reasonable default, >0 assigns the setting value",
294+
"(currently the batching versions of webhook, pubsub, and kafka sinks that are "+
295+
"enabled by changefeed.new_<sink type>_sink_enabled only): <0 disables, 0 assigns "+
296+
"a reasonable default, >0 assigns the setting value",
295297
0,
296298
settings.WithPublic)
297299

0 commit comments

Comments
 (0)