Merge #140626

140626: build: upgrade to go 1.23.6 r=rail,RaduBerinde a=rickystewart

* [ ] Adjust the Pebble tests to run in new version.
* [x] Update [our `go` fork](https://github.com/cockroachdb/go) with a new branch containing our patches. Create a new branch `cockroach-go$GO_VERSION` and take note of the commit ID.
* [x] Update `build/teamcity/internal/release/build-and-publish-patched-go/commit.txt` with the commit ID in the `go` fork.
* [x] Update `build/teamcity/internal/release/build-and-publish-patched-go/impl.sh` with the new `GOVERS` and adjust SHA256 sums as necessary.
* [x] Adjust `GO_FIPS_COMMIT` for the FIPS Go toolchain ([source](./teamcity/internal/release/build-and-publish-patched-go/impl-fips.sh)).
* [x] Run the `Internal / Cockroach / Build / Toolchains / Publish Patched Go for Mac` build configuration in TeamCity with your latest version of the script above. Note the job depends on another job `Build and Publish Patched Go`. That job prints out the SHA256 of all tarballs, which you will need to copy-paste into `WORKSPACE` (see below). `Publish Patched Go for Mac` is an extra step that publishes the *signed* `go` binaries for macOS. That job also prints out the SHA256 of the Mac tarballs in particular.
* [x] Adjust `--`@io_bazel_rules_go//go/toolchain:sdk_version`` in [.bazelrc](../.bazelrc).
* [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit the filenames listed in `sdks` and update all the hashes to match what you built in the step above.
* [x] Bump the version in `WORKSPACE` under `go_download_sdk` for the FIPS version of Go (`go_sdk_fips`).
* [x] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then `bazel fetch `@distdir//:archives`` to ensure you've updated all hashes to the correct value.
* [x] Bump the go version in `go.mod`.
* [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)).
* [x] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`).

Epic: [CRDB-41921](https://cockroachlabs.atlassian.net/browse/CRDB-41921)
Release note (build change): Upgrade to Go 1.23.6

Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>

Author: craig[bot]

.bazelrc

@@ -87,7 +87,7 @@ build:crosslinuxfips '--workspace_status_command=./build/bazelutil/stamp.sh x86_
 build:crosslinuxfips --config=crosslinuxfipsbase
 build:crosslinuxfipsbase --platforms=//build/toolchains:cross_linux
 build:crosslinuxfipsbase --config=cross
-build:crosslinuxfipsbase --@io_bazel_rules_go//go/toolchain:sdk_version=1.22.8fips
+build:crosslinuxfipsbase --@io_bazel_rules_go//go/toolchain:sdk_version=1.23.6fips
 build:crosswindows '--workspace_status_command=./build/bazelutil/stamp.sh x86_64-w64-mingw32'
 build:crosswindows --config=crosswindowsbase
 build:crosswindowsbase --platforms=//build/toolchains:cross_windows

DEPS.bzl

@@ -167,15 +167,15 @@ load(
 go_download_sdk(
     name = "go_sdk",
     sdks = {
-        "darwin_amd64": ("go1.22.8.darwin-amd64.tar.gz", "7ff85f9ce9d4927fa8ac682f0b38107776d1ccfa801e3069a944bab69e31b453"),
-        "darwin_arm64": ("go1.22.8.darwin-arm64.tar.gz", "cb3c233b8e889c5f48edaf0be54ce98b287a44de7473de48a1cf6f4598fa7bf1"),
-        "linux_amd64": ("go1.22.8.linux-amd64.tar.gz", "d5830d065e0650108d429902f0e7e7c0b2514811da0b93270f43633e7a10b18f"),
-        "linux_arm64": ("go1.22.8.linux-arm64.tar.gz", "209dd81bcf115f338f4c8b378a96455e7fc2aec7a0a6f33d14f22beb81d8b682"),
-        "linux_s390x": ("go1.22.8.linux-s390x.tar.gz", "65aa1f666781103129779f8658e7076d3f4fbaf245baaeadd15db0bfa72e3e79"),
-        "windows_amd64": ("go1.22.8.windows-amd64.tar.gz", "d78207ee04c0d4868af32139a1af5035ac7a9f3db107ac32cdfb2b0b5e62a3b6"),
+        "darwin_amd64": ("go1.23.6.darwin-amd64.tar.gz", "12244e63d27a8b9bbdfce10f65da709677136ce9a2f57e60cffdc926f41609cb"),
+        "darwin_arm64": ("go1.23.6.darwin-arm64.tar.gz", "bf611f6840b3fed1b9a893e82d46cc953b65b4cc0bc100421de9de975cec9075"),
+        "linux_amd64": ("go1.23.6.linux-amd64.tar.gz", "bb4c31bf4d57859038933b6dc1a938707a0dd1cd9516ae73ccdc6d746de8cfd9"),
+        "linux_arm64": ("go1.23.6.linux-arm64.tar.gz", "8c34228e3537549627211c9f24e94b3a4ee34d77a673196dc1e37ba5fc3f242d"),
+        "linux_s390x": ("go1.23.6.linux-s390x.tar.gz", "5124de418fa16a77583dff2aa3c267afd0e0348b94a3e8350183ae8352bb7858"),
+        "windows_amd64": ("go1.23.6.windows-amd64.tar.gz", "a643b5f52bf31d7addd81a044e7115f1116291df461f86b7a0210599f22437b8"),
     },
-    urls = ["https://storage.googleapis.com/public-bazel-artifacts/go/20250214-212839/{}"],
-    version = "1.22.8",
+    urls = ["https://storage.googleapis.com/public-bazel-artifacts/go/20250219-170339/{}"],
+    version = "1.23.6",
 )
 
 # To point to a local SDK path, use the following instead. We'll call the
@@ -654,8 +654,8 @@ go_download_sdk(
     # able to provide additional diagnostic information such as the expected version of OpenSSL.
     experiments = ["boringcrypto"],
     sdks = {
-        "linux_amd64": ("go1.22.8fips.linux-amd64.tar.gz", "4d9b9c4193a7648472d80b1f571e9c553aa8615fa1369ac5557365ad0f8ca03a"),
+        "linux_amd64": ("go1.23.6fips.linux-amd64.tar.gz", "6cb9528f849fca5e565b57dd20c17506c33fcb58a8b0a901a77b43277c4aeb0e"),
     },
-    urls = ["https://storage.googleapis.com/public-bazel-artifacts/go/20250214-212839/{}"],
-    version = "1.22.8fips",
+    urls = ["https://storage.googleapis.com/public-bazel-artifacts/go/20250219-170339/{}"],
+    version = "1.23.6fips",
 )

WORKSPACE

@@ -65,6 +65,8 @@ STATICCHECK_CHECKS = [
     "//build/bazelutil/staticcheckanalyzers/sa1028",
     "//build/bazelutil/staticcheckanalyzers/sa1029",
     "//build/bazelutil/staticcheckanalyzers/sa1030",
+    "//build/bazelutil/staticcheckanalyzers/sa1031",
+    "//build/bazelutil/staticcheckanalyzers/sa1032",
     "//build/bazelutil/staticcheckanalyzers/sa2000",
     "//build/bazelutil/staticcheckanalyzers/sa2001",
     "//build/bazelutil/staticcheckanalyzers/sa2002",
@@ -101,6 +103,7 @@ STATICCHECK_CHECKS = [
     "//build/bazelutil/staticcheckanalyzers/sa4029",
     "//build/bazelutil/staticcheckanalyzers/sa4030",
     "//build/bazelutil/staticcheckanalyzers/sa4031",
+    "//build/bazelutil/staticcheckanalyzers/sa4032",
     "//build/bazelutil/staticcheckanalyzers/sa5000",
     "//build/bazelutil/staticcheckanalyzers/sa5001",
     "//build/bazelutil/staticcheckanalyzers/sa5002",
@@ -118,6 +121,7 @@ STATICCHECK_CHECKS = [
     "//build/bazelutil/staticcheckanalyzers/sa6002",
     "//build/bazelutil/staticcheckanalyzers/sa6003",
     "//build/bazelutil/staticcheckanalyzers/sa6005",
+    "//build/bazelutil/staticcheckanalyzers/sa6006",
     "//build/bazelutil/staticcheckanalyzers/sa9001",
     "//build/bazelutil/staticcheckanalyzers/sa9002",
     "//build/bazelutil/staticcheckanalyzers/sa9003",
@@ -126,6 +130,7 @@ STATICCHECK_CHECKS = [
     "//build/bazelutil/staticcheckanalyzers/sa9006",
     "//build/bazelutil/staticcheckanalyzers/sa9007",
     "//build/bazelutil/staticcheckanalyzers/sa9008",
+    "//build/bazelutil/staticcheckanalyzers/sa9009",
     "//build/bazelutil/staticcheckanalyzers/st1000",
     "//build/bazelutil/staticcheckanalyzers/st1001",
     "//build/bazelutil/staticcheckanalyzers/st1003",

build/bazelutil/distdir_files.bzl

@@ -0,0 +1,15 @@
+# Code generated by generate-staticcheck; DO NOT EDIT.
+
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+
+go_library(
+    name = "sa1031",
+    srcs = ["analyzer.go"],
+    importpath = "github.com/cockroachdb/cockroach/build/bazelutil/staticcheckanalyzers/sa1031",
+    visibility = ["//visibility:public"],
+    deps = [
+        "//pkg/testutils/lint/passes/staticcheck",
+        "@co_honnef_go_tools//staticcheck",
+        "@org_golang_x_tools//go/analysis",
+    ],
+)

build/bazelutil/staticcheckanalyzers/def.bzl

@@ -0,0 +1,15 @@
+# Code generated by generate-staticcheck; DO NOT EDIT.
+
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+
+go_library(
+    name = "sa1032",
+    srcs = ["analyzer.go"],
+    importpath = "github.com/cockroachdb/cockroach/build/bazelutil/staticcheckanalyzers/sa1032",
+    visibility = ["//visibility:public"],
+    deps = [
+        "//pkg/testutils/lint/passes/staticcheck",
+        "@co_honnef_go_tools//staticcheck",
+        "@org_golang_x_tools//go/analysis",
+    ],
+)

build/bazelutil/staticcheckanalyzers/sa1031/BUILD.bazel

@@ -0,0 +1,15 @@
+# Code generated by generate-staticcheck; DO NOT EDIT.
+
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+
+go_library(
+    name = "sa4032",
+    srcs = ["analyzer.go"],
+    importpath = "github.com/cockroachdb/cockroach/build/bazelutil/staticcheckanalyzers/sa4032",
+    visibility = ["//visibility:public"],
+    deps = [
+        "//pkg/testutils/lint/passes/staticcheck",
+        "@co_honnef_go_tools//staticcheck",
+        "@org_golang_x_tools//go/analysis",
+    ],
+)