Skip to content

Commit ff2b56d

Browse files
committed
pkg/*: Tag all support metrics with metricVisibility label
This commit modifies the visibility of numerous metrics throughout the codebase, setting them to SUPPORT. This change enhances the clarity of metric categorization and ensures consistent visibility handling across different modules, including metrics related to changefeeds, transactions, and system performance. Part of: CRDB-57282 Epic: CRDB-55082 Release note: None
1 parent 236deb6 commit ff2b56d

File tree

12 files changed

+150
-0
lines changed

12 files changed

+150
-0
lines changed

docs/generated/metrics/metrics.yaml

Lines changed: 73 additions & 0 deletions
Large diffs are not rendered by default.

pkg/ccl/changefeedccl/metrics.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -970,6 +970,7 @@ func newAggregateMetrics(histogramWindow time.Duration, lookup *cidr.Lookup) *Ag
970970
Help: "Number of changefeeds currently executing backfill",
971971
Measurement: "Count",
972972
Unit: metric.Unit_COUNT,
973+
Visibility: metric.Metadata_SUPPORT,
973974
}
974975
metaChangefeedBackfillPendingRanges := metric.Metadata{
975976
Name: "changefeed.backfill_pending_ranges",
@@ -1119,6 +1120,7 @@ func newAggregateMetrics(histogramWindow time.Duration, lookup *cidr.Lookup) *Ag
11191120
Help: "The most any changefeed's persisted checkpoint is behind the present",
11201121
Measurement: "Nanoseconds",
11211122
Unit: metric.Unit_NANOSECONDS,
1123+
Visibility: metric.Metadata_SUPPORT,
11221124
}
11231125
metaChangefeedSpanProgressSkew := metric.Metadata{
11241126
Name: "changefeed.progress_skew.span",

pkg/kv/kvclient/kvcoord/txn_metrics.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ var (
216216
Help: "Number of restarted KV transactions",
217217
Measurement: "KV Transactions",
218218
Unit: metric.Unit_COUNT,
219+
Visibility: metric.Metadata_SUPPORT,
219220
}
220221
// There are two ways we can get "write too old" restarts. In both cases, a
221222
// WriteTooOldError is generated in the MVCC layer. This is intercepted on

pkg/kv/kvserver/liveness/liveness.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ var (
179179
Help: "Number of failed node liveness heartbeats from this node",
180180
Measurement: "Messages",
181181
Unit: metric.Unit_COUNT,
182+
Visibility: metric.Metadata_SUPPORT,
182183
}
183184
metaEpochIncrements = metric.Metadata{
184185
Name: "liveness.epochincrements",

0 commit comments

Comments
 (0)