Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test: TestTenantLogicCCL_read_committed failed [notice is not found] #140062

Closed
cockroach-teamcity opened this issue Jan 29, 2025 · 2 comments · Fixed by #140607
Assignees
Labels
branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 branch-release-25.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 29, 2025

pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test.TestTenantLogicCCL_read_committed failed on release-25.1 @ a53e619877e92319a0a26b9c6902751bd2024b2f:

=== RUN   TestTenantLogicCCL_read_committed
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestTenantLogicCCL_read_committed260365285
    test_log_scope.go:76: use -show-logs to present logs inline
    logic.go:4425: -- test log scope end --
test logs left over in: outputs.zip/logTestTenantLogicCCL_read_committed260365285
--- FAIL: TestTenantLogicCCL_read_committed (11.96s)
=== RUN   TestTenantLogicCCL_read_committed/schema_changes_implicit
[17:55:37] --- progress: /var/lib/engflow/worker/work/0/exec/bazel-out/k8-fastbuild/bin/pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test_/3node-tenant_test.runfiles/com_github_cockroachdb_cockroach/pkg/ccl/logictestccl/testdata/logic_test/read_committed: 55 statements
    logic.go:3062: 
         
        /var/lib/engflow/worker/work/0/exec/bazel-out/k8-fastbuild/bin/pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test_/3node-tenant_test.runfiles/com_github_cockroachdb_cockroach/pkg/ccl/logictestccl/testdata/logic_test/read_committed:311: ALTER SCHEMA s RENAME TO foo
        expected:
            NOTICE: setting transaction isolation level to SERIALIZABLE due to schema change
            
        but found (query options: "noticetrace") :
            
[17:55:43] --- progress: /var/lib/engflow/worker/work/0/exec/bazel-out/k8-fastbuild/bin/pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test_/3node-tenant_test.runfiles/com_github_cockroachdb_cockroach/pkg/ccl/logictestccl/testdata/logic_test/read_committed: 63 statements
[17:55:43] --- done: /var/lib/engflow/worker/work/0/exec/bazel-out/k8-fastbuild/bin/pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test_/3node-tenant_test.runfiles/com_github_cockroachdb_cockroach/pkg/ccl/logictestccl/testdata/logic_test/read_committed with config 3node-tenant: 63 tests, 1 failures
[17:55:44] --- total progress: 63 statements
--- total: 63 tests, 1 failures
    --- FAIL: TestTenantLogicCCL_read_committed/schema_changes_implicit (7.90s)

Parameters:

  • attempt=1
  • run=7
  • shard=48
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

Jira issue: CRDB-46982

@cockroach-teamcity cockroach-teamcity added branch-release-25.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Jan 29, 2025
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Jan 29, 2025
@yuzefovich yuzefovich removed this from SQL Queries Jan 29, 2025
@yuzefovich yuzefovich added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-queries SQL Queries Team labels Jan 29, 2025
@rafiss rafiss removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Jan 30, 2025
@spilchen
Copy link
Contributor

spilchen commented Feb 3, 2025

We're missing an expected notice when renaming a schema using ALTER SCHEMA. What's odd is that the test correctly verifies the same notice for several other DDL commands, but the very last one doesn’t receive it as expected. This seems like a timing issue.

@spilchen spilchen changed the title pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test: TestTenantLogicCCL_read_committed failed pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test: TestTenantLogicCCL_read_committed failed [notice is not found] Feb 3, 2025
@exalate-issue-sync exalate-issue-sync bot added the P-1 Issues/test failures with a fix SLA of 1 month label Feb 4, 2025
@craig craig bot closed this as completed in #140607 Feb 6, 2025
Copy link

blathers-crl bot commented Feb 6, 2025

Based on the specified backports for linked PR #140607, I applied the following new label(s) to this issue: branch-release-24.1, branch-release-24.2, branch-release-24.3. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@craig craig bot closed this as completed in 215d16b Feb 6, 2025
@blathers-crl blathers-crl bot added branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 branch-release-25.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants