Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #398

Open
code423n4 opened this issue May 4, 2023 · 3 comments
Open

QA Report #398

code423n4 opened this issue May 4, 2023 · 3 comments
Labels
bug Something isn't working grade-b high quality report This report is of especially high quality Q-06 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 4, 2023
code423n4 added a commit that referenced this issue May 4, 2023
code423n4 added a commit that referenced this issue May 4, 2023
@c4-pre-sort
Copy link

0xSorryNotSorry marked the issue as high quality report

@c4-pre-sort c4-pre-sort added the high quality report This report is of especially high quality label May 9, 2023
@GalloDaSballo
Copy link

• [L-1] queueWithdrawal() and slashShares() can revert with an out of bounds error if strategies are removed
R
• [L-2] slashQueuedWithdrawal() can leave stuck assets in strategies if passed an incorrect indicesToSkip
L, interesting
• [L-3] Allowing anyone to claim delayed withdrawals on behalf of the users can be detrimental to them
I, they can just not queue it
• [L-4] Missing events for important actions
NC
• [L-5] _claimDelayedWithdrawals emits "empty" events when maxNumberOfDelayedWithdrawalsToClaim == 0
NC

[NC-1] Use i as the increment variable
I, they are replaceable i,j is very common in math

1L 1R 1NC

@c4-judge
Copy link
Contributor

c4-judge commented Jun 2, 2023

GalloDaSballo marked the issue as grade-b

@C4-Staff C4-Staff added the Q-06 label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grade-b high quality report This report is of especially high quality Q-06 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

5 participants