Merge pull request #106 from code-check/v0.3.0

V0.3.0

Author: shunjikonishi

.travis.yml

@@ -2,10 +2,10 @@ language: scala
 
 scala:
   - 2.12.8
-  - 2.13.0
+  - 2.13.1
 
 script:
-  - sbt ++$TRAVIS_SCALA_VERSION test:compile "testOnly *GitHubEventSpec"
+  - sbt ++$TRAVIS_SCALA_VERSION test:compile
 
 # Container-based build environment with faster boot times
 sudo: false

build.sbt

@@ -2,11 +2,11 @@ organization := "io.code-check"
 
 name := """github-api"""
 
-version := "0.3.0-SNAPSHOT"
+version := "0.3.0"
 
-scalaVersion := "2.12.8"
+scalaVersion := "2.13.1"
 
-crossScalaVersions := Seq("2.10.7", "2.11.12", scalaVersion.value, "2.13.0")
+crossScalaVersions := Seq("2.10.7", "2.11.12", "2.12.8", "2.13.1")
 
 description := "The GitHub API from Scala with Async HTTP Client (Netty)"
 

src/main/scala/codecheck/github/models/AbstractJson.scala

@@ -24,7 +24,7 @@ class AbstractJson(value: JValue) {
     }
   }
 
-  def get(path: String) = opt(path).get
+  def get(path: String) = opt(path).getOrElse("")
 
   def dateOpt(path: String): Option[DateTime] = {
     path.split("\\.").foldLeft(value) { (v, s) =>

src/main/scala/codecheck/github/models/Organization.scala

@@ -65,4 +65,4 @@ case class OrganizationInput(
   location: Option[String] = None,
   email: Option[String] = None,
   billing_email: Option[String] = None
-) extends AbstractInput 
+) extends AbstractInput

src/test/scala/CollaboratorOpSpec.scala

@@ -10,11 +10,11 @@ class CollaboratorOpSpec extends FunSpec with api.Constants
 {
 
   describe("addCollaborator"){
-    it("should add Collaborator User to user Repo"){
+    ignore("should add Collaborator User to user Repo"){
       val res = Await.result(api.addCollaborator(user, userRepo, collaboratorUser),TIMEOUT)
       assert(res)
     }
-    it("should fail for non existent User Repo"){
+    ignore("should fail for non existent User Repo"){
       val res = Await.result(api.addCollaborator(user, repoInvalid, collaboratorUser).failed,TIMEOUT)
       res match {
         case e: NotFoundException  =>
@@ -23,17 +23,17 @@ class CollaboratorOpSpec extends FunSpec with api.Constants
     }
   }
   describe("isCollaborator"){
-    it("if it is Collaborator"){
+    ignore("if it is Collaborator"){
       val res = Await.result(api.isCollaborator(user, userRepo, collaboratorUser),TIMEOUT)
       assert(res)
     }
-    it("if it is not a valid Collaborator"){
+    ignore("if it is not a valid Collaborator"){
       val res1 = Await.result(api.isCollaborator(user, userRepo, otherUserInvalid),TIMEOUT)
       assert(res1 == false)
     }
   }
   describe("listCollaborators"){
-    it("should return at least one Collaborator"){
+    ignore("should return at least one Collaborator"){
       val res = Await.result(api.listCollaborators(user, userRepo),TIMEOUT)
       val c = res.find(_.login == collaboratorUser)
       assert(c.isDefined)
@@ -44,12 +44,12 @@ class CollaboratorOpSpec extends FunSpec with api.Constants
     }
   }
  describe("removeCollaborator"){
-    it("should remove the Collaborator"){
+    ignore("should remove the Collaborator"){
       var res = Await.result(api.removeCollaborator(user, userRepo, collaboratorUser),TIMEOUT)
       assert(res == true)
     }
   }
-  it("should fail for non existent User Repo"){
+  ignore("should fail for non existent User Repo"){
     var res = Await.result(api.removeCollaborator(user, repoInvalid, collaboratorUser).failed,TIMEOUT)
     res match {
       case e: NotFoundException  =>

src/test/scala/UserOpSpec.scala

@@ -41,7 +41,7 @@ class UserOpSpec extends FunSpec
   }
 
   describe("updateAuthenticatedUser") {
-    it("if values updated correctly should succeed") {
+    ignore("if values updated correctly should succeed") {
       val input = new UserInput(
         Some("firstname lastname"),
         Some("[email protected]"),