Fix tests checking issue type with IssueType values

Author: ashawley

src/test/scala/IssueOpSpec.scala

@@ -7,6 +7,7 @@ import org.joda.time.DateTimeZone
 import codecheck.github.models.IssueListOption
 import codecheck.github.models.IssueFilter
 import codecheck.github.models.IssueListOption4Repository
+import codecheck.github.models.IssueState
 import codecheck.github.models.IssueStateFilter
 import codecheck.github.models.Issue
 import codecheck.github.models.IssueInput
@@ -39,7 +40,7 @@ class IssueOpSpec extends FunSpec with Constants with BeforeAndAfterAll {
       assert(result.title == "test issue")
       assert(result.user.login == user)
       assert(result.labels.head.name == "question")
-      assert(result.state == "open")
+      assert(result.state == IssueState.open)
       assert(result.locked == false)
       assert(result.assignee.get.login == user)
       assert(result.comments == 0)
@@ -61,7 +62,7 @@ class IssueOpSpec extends FunSpec with Constants with BeforeAndAfterAll {
       assert(result.title == "test issue")
       assert(result.user.login == user)
       assert(result.labels.isEmpty) //Label is not set if user is not the organization member.
-      assert(result.state == "open")
+      assert(result.state == IssueState.open)
       assert(result.locked == false)
       assert(result.assignee.isEmpty) //Assignee is not set if user is not the organization member.
       assert(result.milestone.isEmpty) //Assignee is not set if user is not the organization member.
@@ -172,7 +173,7 @@ class IssueOpSpec extends FunSpec with Constants with BeforeAndAfterAll {
       assert(result.title == "test issue edited")
       assert(result.body.get == "testing again")
       assert(result.labels.head.name == "bug")
-      assert(result.state == "closed")
+      assert(result.state == IssueState.closed)
       assert(result.updated_at.toDateTime(DateTimeZone.UTC).getMillis() - DateTime.now(DateTimeZone.UTC).getMillis() <= 5000)
     }
 
@@ -182,7 +183,7 @@ class IssueOpSpec extends FunSpec with Constants with BeforeAndAfterAll {
       assert(result.body.get == "testing again")
       assert(result.milestone.isEmpty)
       assert(result.labels.isEmpty)
-      assert(result.state == "closed")
+      assert(result.state == IssueState.closed)
       assert(result.updated_at.toDateTime(DateTimeZone.UTC).getMillis() - DateTime.now(DateTimeZone.UTC).getMillis() <= 5000)
     }
   }

src/test/scala/PullRequestOpSpec.scala

@@ -1,6 +1,7 @@
 import org.scalatest.FunSpec
 import scala.concurrent.Await
 
+import codecheck.github.models.IssueState
 import codecheck.github.models.PullRequestInput
 import java.util.Date
 
@@ -10,7 +11,7 @@ class PullRequestOpSpec extends FunSpec with Constants {
     it("with valid repo should succeed") {
       val list = Await.result(api.listPullRequests(otherUser, otherUserRepo), TIMEOUT)
       assert(list.length >= 0)
-      assert(list.exists(_.state == "open"))
+      assert(list.exists(_.state == IssueState.open))
       assert(list.exists(_.base.repo.full_name == s"$otherUser/$otherUserRepo"))
       assert(list.exists(_.base.user.login == otherUser))
       assert(list.exists(_.base.repo.name == otherUserRepo))
@@ -26,11 +27,11 @@ class PullRequestOpSpec extends FunSpec with Constants {
       val input = PullRequestInput(title, "githubapi-test-pr", "master", Some("PullRequest body"))
       val result = Await.result(api.createPullRequest(username, reponame, input), TIMEOUT)
       assert(result.title == title)
-      assert(result.state == "open")
+      assert(result.state == IssueState.open)
 
       val result2 = Await.result(api.closePullRequest(username, reponame, result.number), TIMEOUT)
       assert(result2.title == title)
-      assert(result2.state == "closed")
+      assert(result2.state == IssueState.closed)
     }
 
   }

src/test/scala/events/GitHubEventSpec.scala

@@ -36,7 +36,7 @@ class GitHubEventSpec extends FunSpec with Matchers with Inside
               assert(issue.title === "Spelling error in the README file")
             }
             it("should have a state") {
-              assert(issue.state === "open")
+              assert(issue.state === models.IssueState.open)
             }
             it("should have a body") {
               val exp = "It looks like you accidently spelled 'commit' with two 't's."
@@ -77,7 +77,7 @@ class GitHubEventSpec extends FunSpec with Matchers with Inside
               assert(pr.title === "Update the README with new information")
             }
             it("should have a state") {
-              assert(pr.state === "open")
+              assert(pr.state === models.IssueState.open)
             }
             it("should have a body") {
               val exp = "This is a pretty simple change that we need to pull into master."