Skip to content

Issue related API #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
20 tasks done
shunjikonishi opened this issue Apr 17, 2015 · 2 comments
Closed
20 tasks done

Issue related API #3

shunjikonishi opened this issue Apr 17, 2015 · 2 comments
Assignees

Comments

@shunjikonishi
Copy link
Contributor

models

  • Issue
  • IssueListOption4Repo

operations

  • listAllIssues
  • listUerIssues
  • listOrgIssues
  • listRepositoryIssues
  • getIssue
  • createIssue
  • editIssue
  • assign
  • unassign

test

  • listAllIssues
  • listUerIssues
  • listOrgIssues
  • listRepositoryIssues
  • getIssue
  • createIssue
  • editIssue
  • assign
  • unassign
@shunjikonishi shunjikonishi changed the title Implement issue related API Issue related API May 5, 2015
@shunjikonishi shunjikonishi modified the milestone: Sprint3 May 5, 2015
@shunjikonishi
Copy link
Contributor Author

@fanwashere

In this issue, I've already implement almost all methods.
But I've not written tests.

I asked you to finish this issue.

fanwashere added a commit that referenced this issue May 22, 2015
@shunjikonishi
Copy link
Contributor Author

@fanwashere @da0shi @sukeshni

This is a sample for input parameter class that allowed

  • "*"
  • "none"
  • Or any int
sealed abstract class MilestoneSearchOption {
  val value: JValue
}

object MilestoneSearchOption {
  case object All extends MilestoneSearchOption {
    val value = JString("*")
  }

  case object NotAssigned extends MilestoneSearchOption {
    val value = JString("none")
  }

  case class Specified(number: Int) extends MilestoneSearchOption {
    val value = JInt(number)
  }

  def apply(number: Int) = Specified(number)

}

fanwashere added a commit that referenced this issue May 22, 2015
Added the last missing method listRepositoryIssue.

Implemented tests for create, get, and edit issue, but not done tests for listing and filtering issues.

listRepositoryIssue method works but untested.
fanwashere added a commit that referenced this issue May 25, 2015
fanwashere added a commit that referenced this issue May 26, 2015
fanwashere added a commit that referenced this issue May 26, 2015
fanwashere added a commit that referenced this issue May 26, 2015
Added the last missing method listRepositoryIssue.

Implemented tests for create, get, and edit issue, but not done tests for listing and filtering issues.

listRepositoryIssue method works but untested.
fanwashere added a commit that referenced this issue May 26, 2015
fanwashere added a commit that referenced this issue May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants