feat: added extension 'Spotless Gradle', configured so it runs spotlessApply - Xavier Cruz #436
Conversation
| @@ -15,4 +15,12 @@ | |||
| "[javascriptreact]": { | |||
| "editor.defaultFormatter": "esbenp.prettier-vscode" | |||
| }, | |||
| "[java]": { | |||
There was a problem hiding this comment.
Not working when I test locally. Did you test this?
There was a problem hiding this comment.
I have tested it, it worked locally. Maybe something in the configuration is messed up? I'll check this out tmr
There was a problem hiding this comment.
after some further digging it looks like the activation events for this plugin are
workspaceContains:gradlew
workspaceContains:gradlew.bat
and since gradle is inside of the children folders and not the parent workspace i dont think it will work. Ill make a new repo and test this out
There was a problem hiding this comment.
Yup that was the issue. It works as intended in the new repository, even lints when something is not spotless
There was a problem hiding this comment.
There is another extension which is more bare bones thats called Run On Save. the only issue im facing currently is how to determine where the java project was created at.
There was a problem hiding this comment.
Nice. I was proud to see your feature request in the plugin repo when I walked the TAs through the issue.
|
Lmk if you want me to clean up the commits. I could revert this whole branch and just add the extension to the devcontainer and commit the one liner |
Yeah, I think you need to do that. I can't see what changes you made |
Credits to David Smith for showing me the extension and telling me of this extra credit. Credits also to Joseph and Pablo
Fixes #421