Small refactoring to group binlogs computations

Author: Brice Figureau

mysql-snmp

@@ -744,7 +744,7 @@ sub fetch_mysql_data {
 
                 # Older versions of MySQL may not have the File_size column in the
                 # results of the command.
-                if (exists($newrow{'file_size'})) {
+                if (exists($newrow{'file_size'}) && $newrow{'file_size'} > 0) {
                     push(@binlogs, $newrow{'file_size'});
                 }
                 else {
@@ -753,6 +753,13 @@ sub fetch_mysql_data {
             }
         }
 
+        if (scalar @binlogs) {
+            $status{'binary_log_space'} = 0;
+            foreach my $log (@binlogs) {
+                $status{'binary_log_space'} += $log;
+            }
+        }
+
         # Get SHOW INNODB STATUS and extract the desired metrics from it.
         if ($opt{innodb} && $status{'have_innodb'} eq 'YES') {
             my $innodb_array = $dbh->selectall_arrayref("SHOW /*!50000 ENGINE*/ INNODB STATUS",{Slice => {}});
@@ -822,13 +829,6 @@ sub fetch_mysql_data {
             }
         }
 
-        if (scalar @binlogs) {
-            $status{'binary_log_space'} = 0;
-            foreach my $log (@binlogs) {
-                $status{'binary_log_space'} += $log;
-            }
-        }
-
         $dbh->disconnect();
 
         my %trans;