Feat: Add logging and improve command instance creation

Introduced logging using Microsoft.Extensions.Logging for better diagnostics during command handling. Refactored instance creation logic into a new `TryCreateCommandInstance` method to improve readability and error handling. Added null checks and fallback behavior to handle scenarios where services or commands cannot be resolved.

Author: AnnaSasDev

src/CodeOfChaos.CliArgsParser/CliParser.cs

@@ -2,6 +2,8 @@
 // Imports
 // ---------------------------------------------------------------------------------------------------------------------
 using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Logging;
+using System.Diagnostics.CodeAnalysis;
 using System.Text.RegularExpressions;
 
 namespace CodeOfChaos.CliArgsParser;
@@ -11,17 +13,19 @@ namespace CodeOfChaos.CliArgsParser;
 public partial class CliParser : ICliParser {
     public required Lazy<IServiceProvider>? ServiceProvider { get; init; }
     public required ICommandProvider CommandProvider { get; init; }
-    
-    [GeneratedRegex(@"\s+")] private static partial Regex FindEmptySpacesRegex { get; }
 
+    private ILogger<CliParser>? Logger => ServiceProvider?.Value.GetService<ILogger<CliParser>>();
+
+    [GeneratedRegex(@"\s+")] private static partial Regex FindEmptySpacesRegex { get; }
+    
     // -----------------------------------------------------------------------------------------------------------------
     // Methods
     // -----------------------------------------------------------------------------------------------------------------
-    internal CliParser() { }
+    internal CliParser() {}
     public static CliParserBuilder CreateBuilder() {
         return new CliParserBuilder();
     }
-    
+
     public ValueTask ExecuteAsync(string[] args, CancellationToken ct = default) => ExecuteAsync(ArgsInputHelper.ToOneLine(args), ct);
     public async ValueTask ExecuteAsync(string input, CancellationToken ct = default) {
         input = input.Replace("\\\"", "\"");
@@ -32,21 +36,47 @@ public async ValueTask ExecuteAsync(string input, CancellationToken ct = default
             await Task.WhenAll(tasks);
             return;
         }
-        
+
         string[] tokens = FindEmptySpacesRegex.Split(input);
         string commandName = tokens[0];
         string parameterInput = string.Join(" ", tokens.Skip(1));
 
-        if (!CommandProvider.TryGetCommand(commandName, out Type? commandType)) throw new Exception("no Command found");
-        
-        ICliCommand? command = ServiceProvider is not null
-            ? (ICliCommand?)ActivatorUtilities.CreateInstance(ServiceProvider.Value, commandType)
-            : Activator.CreateInstance(commandType) as ICliCommand;
+        if (!CommandProvider.TryGetCommand(commandName, out Type? commandType)) {
+            if (Logger is null) throw new Exception($"Could not find command by name {commandName}");
+            Logger.LogWarning("Could not find command by name {name}", commandName);
+            return;
+        }
+
+        if (!TryCreateCommandInstance(commandType, out ICliCommand? command)) {
+            if (Logger is null) throw new Exception($"Could not instantiate command with type {commandType.FullName}");
+            Logger.LogWarning("Could not instantiate command with type {type}", commandType.FullName);
+            return;
+            
+        }
 
-        
-        if (command is null) throw new Exception("no Command found");
-        
         ParameterDictionary parameterDictionary = ParameterDictionary.FromString(parameterInput);
         await command.StartExecution(parameterDictionary, ct);
     }
+
+    private bool TryCreateCommandInstance(Type commandType, [NotNullWhen(true)] out ICliCommand? command) {
+        try {
+            if (ServiceProvider is null) {
+                object? directInstance = Activator.CreateInstance(commandType);
+                command = directInstance as ICliCommand;
+                return command is not null;
+            }
+
+            IServiceScope scope = ServiceProvider.Value.CreateScope();
+            object diInstance = ActivatorUtilities.CreateInstance(scope.ServiceProvider, commandType);
+            command = diInstance as ICliCommand;
+            return command is not null;
+        }
+        catch (Exception e) {
+            // Throw if we cant log
+            if (Logger is null) throw;
+            Logger.LogWarning(e, "Failed to create command instance");
+            command = null;
+            return false;
+        }
+    }
 }

src/CodeOfChaos.CliArgsParser/CodeOfChaos.CliArgsParser.csproj

@@ -34,6 +34,7 @@
     <ItemGroup>
       <PackageReference Include="CodeOfChaos.Extensions" Version="0.66.1" />
       <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="9.0.5" />
+      <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.5" />
     </ItemGroup>
 
 </Project>