Fix: Correct key comparison logic in service conditions

Author: AnnaSasDev

src/CodeOfChaos.Testing.TUnit/Conditions/Library/ContainsKeyedServiceImplementationCondition.cs

@@ -24,9 +24,17 @@ protected override ValueTask<AssertionResult> GetResult(IServiceCollection? actu
     }
 
     private bool Predicate(ServiceDescriptor descriptor) {
+        if (descriptor.ServiceKey == null && key == null)
+            return descriptor.IsKeyedService
+                && descriptor.ServiceType == serviceType
+                && descriptor.KeyedImplementationType == implementationType;
+            
+        if (descriptor.ServiceKey == null || key == null)
+            return false;
+            
         return descriptor.IsKeyedService
             && descriptor.ServiceType == serviceType
             && descriptor.KeyedImplementationType == implementationType
-            && ReferenceEquals(descriptor.ServiceKey, key);
+            && (descriptor.ServiceKey.Equals(key) || key.Equals(descriptor.ServiceKey));
     }
-}
+}

src/CodeOfChaos.Testing.TUnit/Conditions/Library/ContainsKeyedServiceTypeCondition.cs

@@ -1,4 +1,5 @@
-// ---------------------------------------------------------------------------------------------------------------------
+
+// ---------------------------------------------------------------------------------------------------------------------
 // Imports
 // ---------------------------------------------------------------------------------------------------------------------
 using Microsoft.Extensions.DependencyInjection;
@@ -21,9 +22,19 @@ protected override ValueTask<AssertionResult> GetResult(IServiceCollection? actu
         return actualValue.Any(descriptor =>
             descriptor.IsKeyedService
             && descriptor.ServiceType == serviceType
-            && ReferenceEquals(descriptor.ServiceKey, key)
+            && CompareKeys(descriptor.ServiceKey, key)
         )
             ? AssertionResult.Passed
             : FailWithMessage($"No keyed service with type {serviceType.Name} and key {key} has been registered.");
     }
-}
+
+    private static bool CompareKeys(object? descriptorKey, object? expectedKey) {
+        if (descriptorKey == null && expectedKey == null)
+            return true;
+            
+        if (descriptorKey == null || expectedKey == null)
+            return false;
+            
+        return descriptorKey.Equals(expectedKey) || expectedKey.Equals(descriptorKey);
+    }
+}

src/CodeOfChaos.Testing.TUnit/Conditions/Library/DoesNotContainKeyedServiceImplementationCondition.cs

@@ -24,9 +24,17 @@ protected override ValueTask<AssertionResult> GetResult(IServiceCollection? actu
     }
 
     private bool Predicate(ServiceDescriptor descriptor) {
+        if (descriptor.ServiceKey == null && key == null)
+            return descriptor.IsKeyedService
+                && descriptor.ServiceType == serviceType
+                && descriptor.KeyedImplementationType == implementationType;
+            
+        if (descriptor.ServiceKey == null || key == null)
+            return false;
+        
         return descriptor.IsKeyedService
             && descriptor.ServiceType == serviceType
             && descriptor.KeyedImplementationType == implementationType
-            && ReferenceEquals(descriptor.ServiceKey, key);
+            && (descriptor.ServiceKey.Equals(key) || key.Equals(descriptor.ServiceKey));
     }
 }

src/CodeOfChaos.Testing.TUnit/Conditions/Library/DoesNotContainKeyedServiceTypeCondition.cs

@@ -1,4 +1,5 @@
-// ---------------------------------------------------------------------------------------------------------------------
+
+// ---------------------------------------------------------------------------------------------------------------------
 // Imports
 // ---------------------------------------------------------------------------------------------------------------------
 using Microsoft.Extensions.DependencyInjection;
@@ -18,12 +19,21 @@ protected override ValueTask<AssertionResult> GetResult(IServiceCollection? actu
         if (actualValue is null)
             return AssertionResult.Fail($"{nameof(IServiceCollection)} is null");
 
-        return actualValue.Any(descriptor =>
-            descriptor.IsKeyedService
-            && descriptor.ServiceType == serviceType
-            && ReferenceEquals(descriptor.ServiceKey, key)
-        )
+        return actualValue.Any(Predicate)
             ? FailWithMessage($"Found service of type {serviceType.Name} registered with key {key}")
             : AssertionResult.Passed;
     }
-}
+
+    private bool Predicate(ServiceDescriptor descriptor) {
+        if (descriptor.ServiceKey == null && key == null)
+            return descriptor.IsKeyedService
+                && descriptor.ServiceType == serviceType;
+            
+        if (descriptor.ServiceKey == null || key == null)
+            return false;
+        
+        return descriptor.IsKeyedService
+            && descriptor.ServiceType == serviceType
+            && (descriptor.ServiceKey.Equals(key) || key.Equals(descriptor.ServiceKey));
+    }
+}