Skip to content

Commit 6f53af2

Browse files
committed
Allow Faraday 2.x, by switching from faraday-middleware to the new faraday_follow-redirects gem
The new gem is compatible with both faraday 1 and 2, while faraday-middleware (which included a redirect middleware) has a gemspec that does not allow faraday 2.
1 parent 614cc8c commit 6f53af2

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

lib/oai/client.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,8 @@ def initialize(base_url, options={})
9595
follow_redirects = 5 if follow_redirects == true
9696

9797
if follow_redirects
98-
require 'faraday_middleware'
98+
require 'faraday/follow_redirects'
99+
builder.use Faraday::FollowRedirects::Middleware
99100
builder.response :follow_redirects, :limit => follow_redirects.to_i
100101
end
101102
builder.adapter :net_http

ruby-oai.gemspec

+4-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@ Gem::Specification.new do |s|
1212
s.executables = 'oai'
1313

1414
s.add_dependency('builder', '>=3.1.0')
15-
s.add_dependency('faraday')
16-
s.add_dependency('faraday_middleware')
15+
s.add_dependency('faraday', "< 3")
16+
#s.add_dependency('faraday_middleware')
17+
s.add_dependency("faraday-follow_redirects", ">= 0.3.0", "< 2")
18+
1719

1820
s.add_development_dependency "activerecord", ">= 5.2.0", "< 6.1"
1921
s.add_development_dependency "appraisal"

test/client/tc_http_client.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ def test_http_client_handles_trailing_slash_redirects
5858
end
5959

6060
faraday_stub = Faraday.new do |builder|
61-
require 'faraday_middleware'
62-
builder.use FaradayMiddleware::FollowRedirects
61+
require 'faraday/follow_redirects'
62+
builder.use Faraday::FollowRedirects::Middleware
6363
builder.adapter :test, stubs
6464
end
6565

0 commit comments

Comments
 (0)