Skip to content

Commit 757efa6

Browse files
committed
log to stdout if no logfile; do not send mail if no email
1 parent 2ec0d90 commit 757efa6

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

Diff for: lib/oai/harvester/logging.rb

+3-4
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,9 @@ class Harvest
1111
def initialize(*args)
1212
orig_init(*args)
1313
@summary = []
14-
@logger = Logger.new(File.join(@config.logfile, "harvester.log"),
15-
shift_age = 'weekly') if @config.logfile
14+
@logger = @config.logfile ? Logger.new(File.join(@config.logfile, "harvester.log"), 'weekly') : Logger.new(STDOUT)
1615
@logger.datetime_format = "%Y-%m-%d %H:%M"
17-
16+
1817
# Turn off logging if no logging directory is specified.
1918
@logger.level = Logger::FATAL unless @config.logfile
2019
end
@@ -25,7 +24,7 @@ def start(sites = nil, interactive = false)
2524
orig_start(sites)
2625
begin
2726
OAI::Harvester::
28-
Mailer.send(@config.mail_server, @config.email, @summary)
27+
Mailer.send(@config.mail_server, @config.email, @summary) if @config.email
2928
rescue
3029
@logger.error { "Error sending out summary email: #{$!}"}
3130
end

0 commit comments

Comments
 (0)