Skip to content

Commit 08b07a5

Browse files
committed
filesystem s3 fix
1 parent 62ef063 commit 08b07a5

File tree

4 files changed

+23
-9
lines changed

4 files changed

+23
-9
lines changed

drf_friend/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22
__title__ = 'DRF Friend'
3-
__version__ = '0.0.11'
3+
__version__ = '0.0.29'
44
__author__ = 'Mostafa'
55

66
# Version synonym

drf_friend/filesystem/storage.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,14 @@ def __init__(self, disk='local'):
66
self.disk = disk
77
self.local_storage = LocalStorage()
88
self.s3_storage = None
9+
self.set_disk(disk)
10+
911

10-
def disk(self, storage_type):
11-
self.disk = storage_type
12-
12+
def set_disk(self, storage_type):
1313
if self.disk == 's3':
14-
self.s3_storage = S3Storage('your-s3-bucket')
14+
self.s3_storage = S3Storage()
15+
else:
16+
self.disk = storage_type
1517

1618
def put(self, path, contents):
1719
if self.disk == 'local':

drf_friend/filesystem/the_disks/s3.py

+15-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,22 @@
11
import boto3
22
from botocore.exceptions import ClientError
3+
from drf_friend.env import getEnv
4+
5+
# Retrieve environment variables
6+
aws_access_key_id = getEnv('AWS_ACCESS_KEY_ID')
7+
aws_secret_access_key = getEnv('AWS_SECRET_ACCESS_KEY')
8+
aws_region = getEnv('AWS_REGION')
9+
bucket_name = getEnv('BUCKET_NAME')
310

411
class S3Storage:
5-
def __init__(self, s3_bucket):
6-
self.s3_bucket = s3_bucket
7-
self.s3_client = boto3.client('s3')
12+
def __init__(self):
13+
self.s3_bucket = bucket_name
14+
self.s3_client = boto3.client(
15+
's3',
16+
aws_access_key_id=aws_access_key_id,
17+
aws_secret_access_key=aws_secret_access_key,
18+
region_name=aws_region
19+
)
820

921
def put(self, path, contents):
1022
try:

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def read(f):
3636
setup(
3737
# Package metadata
3838
name='drf-friend',
39-
version='0.0.28',
39+
version='0.0.29',
4040
url='https://drf-friend.code4mk.org/',
4141
author='Mostafa Kamal',
4242
author_email='[email protected]',

0 commit comments

Comments
 (0)