Allure report does not show diff screenshot #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ashiots2 opened this issue Oct 23, 2019 · 1 comment

Assignees

ashiots2 commented Oct 23, 2019

Allure report shows the diff screenshot as corrupted; since the fs.writeFile() call is not finished when allure.addAttachment is called.

I replaced the fs.writeFile() call with fs.writeFileSync() in #51

Also covered some warnings the IDE highlighted.

Again, looking forward to your review :)

puneet0191 assigned ashiots2

puneet0191 closed this as completed

Member

puneet0191 commented Nov 1, 2019

Fixed thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment