-
Notifications
You must be signed in to change notification settings - Fork 54
FEATURE: allow resemble.compare even if dimensions are not the same #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks a lot, I think it should fine to add this check as an optional parameter, which is defaulted to true. @jpmschuler could you please have a PR for this request, if you have time. It would be great help. I will make a new release. |
jpmschuler
added a commit
to jpmschuler/codeceptjs-resemblehelper
that referenced
this issue
Sep 13, 2021
puneet0191
added a commit
that referenced
this issue
Nov 6, 2021
* Fixed optional param in JSDoc and generated TS definition (#99) * [TASK] fix relative paths for Mochawesome context screenshots (#97) * [TASK] fix relative paths for Mochawesome context screenshots * [TASK] improve relative path generation for cases where report is not in default folder * [TASK] switch to Path.relative * [TASK] add more pessimistic check for undefined options * [TASK] resolveRelativePath should not be public * [FEATURE] allow resemble.compare even if dimensions are not the same (#96) * [FEATURE] allow resemble.compare even if dimensions are not the same \n\nsee #94 * fix default value overriding custom value "false" * Update Version, Prepare for release. Co-authored-by: Jaromir Obr <[email protected]> Co-authored-by: jpmschuler <[email protected]>
Thank you, fixed with https://github.com/codeceptjs/codeceptjs-resemblehelper/releases/tag/v1.9.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation says:
which is found in the code
codeceptjs-resemblehelper/index.js
Lines 79 to 83 in 3d9974d
However the underlying resemble.js works just fine in calculating the diff percentage and tolerance and taking that into account.
I propose to make this check optional and thus introduce an option/parameter to skip that check
Background:
We use visual regression testing for webpages and as we allow some tolerance for minor layout changes. But this could also make a full page screenshot some few pixel longer.
This should be able to fail the test (as is the state now), but in fact only with 0 tolerance. However if you have a tolerance defined, tests should be able to run fine nevertheless if the change is within the tolerance.
The text was updated successfully, but these errors were encountered: