Skip to content

Commit a8992a1

Browse files
committed
Include separator in directory expansion check
The intent of this function is to expand include_paths to individual files and add each as a unit of work to the forking server. This gives the maximum amount of concurrency given the server's configuration. The check to see if the include_path was a directory prepended "/code", but without a separator. For example, "/coodapp/lib/" instead of "/code/app/lib". The check would return false and the entire directory would be added as a single unit of work. This meant we achieved almost no concurrency and customer's with large repositories would time out.
1 parent b2e6fd7 commit a8992a1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: Runner.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ public function queueWithIncludePaths()
3535
{
3636
foreach ($this->config['include_paths'] as $f) {
3737
if ($f !== '.' and $f !== '..') {
38-
if (is_dir("/code$f")) {
39-
$this->queuePaths("/code$f", "$f/");
38+
if (is_dir("/code/$f")) {
39+
$this->queuePaths("/code/$f", "$f");
4040
continue;
4141
}
4242
$this->server->addwork(array("/code/$f"));

0 commit comments

Comments
 (0)