Handle no base report (#143)

* Handle no base report

* Added tests

* added assertion

Author: febg

internal_api/compare/serializers.py

@@ -37,10 +37,15 @@ class ComparisonFullSrcSerializer(serializers.Serializer):
     untracked_files = serializers.SerializerMethodField()
 
     def __init__(self, obj, *args, **kwargs):
-        self.tracked_file_names = set(
-            [f.name for f in obj.base_report.file_reports()] +
-            [f.name for f in obj.head_report.file_reports()]
-        )
+        if (obj.base_report):
+            self.tracked_file_names = set(
+                [f.name for f in obj.base_report.file_reports()] +
+                [f.name for f in obj.head_report.file_reports()]
+            )
+        else:
+            self.tracked_file_names = set(
+                [f.name for f in obj.head_report.file_reports()]
+            )
         super().__init__(obj, *args, **kwargs)
 
     def get_tracked_files(self, obj):

internal_api/tests/unit/views/test_compare_view.py

@@ -436,7 +436,7 @@ def setUp(self):
         self.repo = RepositoryFactory()
         self.commit_base = CommitFactory(repository=self.repo)
         self.commit_head = CommitFactory(repository=self.repo)
-
+        self.commit_base_no_report = CommitFactory(repository=self.repo, report=None)
         self.client.force_login(user=self.repo.author)
 
     def test_returns_calculated_diff_data_with_commit_refs(self, mocked_comparison, *_):
@@ -566,3 +566,31 @@ def test_correctly_sorts_tracked_and_untracked_files(self, mocked_head_file_repo
             if file_name != made_up_file:
                 continue
             assert file_name in response.data["untracked_files"]
+
+    def test_missing_base_report(self, mocked_comparison, *_):
+        self._configure_comparison_mock_with_commit_factory_report(mocked_comparison)
+        expected_data = {
+            'tracked_files': {
+                'awesome/__init__.py': {
+                    'segments': True},
+                    'tests/__init__.py': {
+                        'segments': True
+                    },
+                    'tests/test_sample.py': {
+                        'segments': True
+                    }
+                },
+            'untracked_files': []
+        }
+        response = self._get_compare_src(
+            kwargs={
+                "orgName": self.repo.author.username,
+                "repoName": self.repo.name
+            },
+            query_params={
+                "head": self.commit_head.commitid,
+                "base": self.commit_base_no_report.commitid
+            }
+        )
+        assert response.status_code == status.HTTP_200_OK
+        assert response.data == expected_data

services/archive.py

@@ -248,6 +248,8 @@ def build_report_from_commit(self, commit):
         Returns:
             SerializableReport: A report with all information from such commit
         """
+        if not commit.report:
+            return None
         commitid = commit.commitid
         chunks = ArchiveService(commit.repository).read_chunks(commitid)
         files = commit.report['files']

services/tests/test_archive.py

@@ -117,3 +117,8 @@ def test_build_report_from_commit_with_flags(self, db, mocker, codecov_vcr):
         assert tuple(file_3.totals) == (0, 7, 2, 5, 0, '28.57143', 0, 0, 0, 0, 0, 0, 0)
         mocked.assert_called_with('abf6d4d')
         assert list(res.totals) == [3, 20, 3, 17, 0, '15.00000', 0, 0, 0, 2, 0, 0, 0]
+
+    def test_build_report_from_commit_no_report(self, db, mocker, codecov_vcr):
+        commit = CommitFactory(report=None)
+        report = ReportService().build_report_from_commit(commit)
+        assert report is None