fix: only call commit_update task when commit is newly created (#804)

Author: joseph-sentry

upload/serializers.py

@@ -5,6 +5,7 @@
 from core.models import Commit, Repository
 from reports.models import CommitReport, ReportResults, ReportSession, RepositoryFlag
 from services.archive import ArchiveService
+from services.task import TaskService
 
 
 class FlagListField(serializers.ListField):
@@ -136,9 +137,15 @@ class Meta:
     def create(self, validated_data):
         repo = validated_data.pop("repository", None)
         commitid = validated_data.pop("commitid", None)
-        commit, _ = Commit.objects.get_or_create(
+        commit, created = Commit.objects.get_or_create(
             repository=repo, commitid=commitid, defaults=validated_data
         )
+
+        if created:
+            TaskService().update_commit(
+                commitid=commit.commitid, repoid=commit.repository.repoid
+            )
+
         return commit
 
 

upload/tests/views/test_commits.py

@@ -197,7 +197,7 @@ def test_create_commit_already_exists(db, client, mocker):
     }
     assert response.status_code == 201
     assert expected_response == response_json
-    mocked_call.assert_called_with(commitid=commit.commitid, repoid=repository.repoid)
+    mocked_call.assert_not_called()
 
 
 @pytest.mark.parametrize("branch", ["main", "someone:main", "someone/fork:main"])

upload/views/commits.py

@@ -13,7 +13,6 @@
     repo_auth_custom_exception_handler,
 )
 from core.models import Commit
-from services.task import TaskService
 from upload.helpers import generate_upload_sentry_metrics_tags
 from upload.serializers import CommitSerializer
 from upload.views.base import GetterMixin
@@ -63,14 +62,14 @@ def perform_create(self, serializer):
             ),
         )
         repository = self.get_repo()
+
         commit = serializer.save(repository=repository)
+
         log.info(
             "Request to create new commit",
             extra=dict(repo=repository.name, commit=commit.commitid),
         )
-        TaskService().update_commit(
-            commitid=commit.commitid, repoid=commit.repository.repoid
-        )
+
         sentry_metrics.incr(
             "upload",
             tags=generate_upload_sentry_metrics_tags(
@@ -82,4 +81,5 @@ def perform_create(self, serializer):
                 position="end",
             ),
         )
+
         return commit