feat: Track Upload Sent events for Coverage/BA/TA (attempt 2) (#1195)

Author: spalmurray-codecov

upload/tests/views/test_bundle_analysis.py

@@ -10,6 +10,7 @@
     OrganizationLevelTokenFactory,
 )
 from shared.django_apps.core.tests.factories import CommitFactory, RepositoryFactory
+from shared.events.amplitude import UNKNOWN_USER_OWNERID
 
 from core.models import Commit
 from services.redis_configuration import get_redis_connection
@@ -27,6 +28,9 @@ def test_upload_bundle_analysis_success(db, client, mocker, mock_redis):
         "shared.storage.MinioStorageService.create_presigned_put",
         return_value="test-presigned-put",
     )
+    mock_amplitude = mocker.patch(
+        "shared.events.amplitude.AmplitudeEventPublisher.publish"
+    )
 
     repository = RepositoryFactory.create()
     commit_sha = "6fd5b89357fc8cdf34d6197549ac7c6d7e5977ef"
@@ -103,6 +107,19 @@ def test_upload_bundle_analysis_success(db, client, mocker, mock_redis):
         },
     )
 
+    # emits Amplitude event
+    mock_amplitude.assert_called_with(
+        "Upload Received",
+        {
+            "user_ownerid": UNKNOWN_USER_OWNERID,
+            "ownerid": commit.repository.author.ownerid,
+            "repoid": commit.repository.repoid,
+            "commitid": commit.id,
+            "pullid": commit.pullid,
+            "upload_type": "Bundle",
+        },
+    )
+
 
 @pytest.mark.django_db(databases={"default", "timeseries"})
 @override_settings(SHELTER_SHARED_SECRET="shelter-shared-secret")

upload/tests/views/test_test_results.py

@@ -13,6 +13,7 @@
     OwnerFactory,
     RepositoryFactory,
 )
+from shared.events.amplitude import UNKNOWN_USER_OWNERID
 
 from services.redis_configuration import get_redis_connection
 from services.task import TaskService
@@ -25,6 +26,9 @@ def test_upload_test_results(db, client, mocker, mock_redis):
         "shared.storage.MinioStorageService.create_presigned_put",
         return_value="test-presigned-put",
     )
+    mock_amplitude = mocker.patch(
+        "shared.events.amplitude.AmplitudeEventPublisher.publish"
+    )
 
     owner = OwnerFactory(service="github", username="codecov")
     repository = RepositoryFactory.create(author=owner)
@@ -115,6 +119,19 @@ def test_upload_test_results(db, client, mocker, mock_redis):
         },
     )
 
+    # emits Amplitude event
+    mock_amplitude.assert_called_with(
+        "Upload Received",
+        {
+            "user_ownerid": UNKNOWN_USER_OWNERID,
+            "ownerid": commit.repository.author.ownerid,
+            "repoid": commit.repository.repoid,
+            "commitid": commit.id,
+            "pullid": commit.pullid,
+            "upload_type": "Test results",
+        },
+    )
+
 
 def test_test_results_org_token(db, client, mocker, mock_redis):
     mocker.patch.object(TaskService, "upload")

upload/tests/views/test_upload_coverage.py

@@ -104,6 +104,9 @@ def test_upload_coverage_post(db, mocker):
     upload_task_mock = mocker.patch(
         "upload.views.uploads.trigger_upload_task", return_value=True
     )
+    amplitude_mock = mocker.patch(
+        "shared.events.amplitude.AmplitudeEventPublisher.publish"
+    )
 
     repository = RepositoryFactory(
         name="the_repo1", author__username="codecov", author__service="github"
@@ -151,6 +154,17 @@ def test_upload_coverage_post(db, mocker):
         response_json.get("url")
         == f"{settings.CODECOV_DASHBOARD_URL}/{repository.author.service}/{repository.author.username}/{repository.name}/commit/{commit.commitid}"
     )
+    amplitude_mock.assert_called_with(
+        "Upload Received",
+        {
+            "user_ownerid": commit.author.ownerid,
+            "ownerid": commit.repository.author.ownerid,
+            "repoid": commit.repository.repoid,
+            "commitid": commit.id,
+            "pullid": commit.pullid,
+            "upload_type": "Coverage report",
+        },
+    )
 
     assert ReportSession.objects.filter(
         report__commit=commit,

upload/views/bundle_analysis.py

@@ -11,6 +11,7 @@
 from rest_framework.views import APIView
 from shared.api_archive.archive import ArchiveService
 from shared.bundle_analysis.storage import StoragePaths, get_bucket_name
+from shared.events.amplitude import UNKNOWN_USER_OWNERID, AmplitudeEventPublisher
 from shared.metrics import Counter, inc_counter
 
 from codecov_auth.authentication.repo_auth import (
@@ -140,6 +141,20 @@ def post(self, request: HttpRequest) -> Response:
             },
         )
 
+        AmplitudeEventPublisher().publish(
+            "Upload Received",
+            {
+                "user_ownerid": commit.author.ownerid
+                if commit.author
+                else UNKNOWN_USER_OWNERID,
+                "ownerid": repo.author.ownerid,
+                "repoid": repo.repoid,
+                "commitid": commit.id,  # Not commit.commitid, we do not want a commit SHA here!
+                "pullid": commit.pullid,
+                "upload_type": "Bundle",
+            },
+        )
+
         storage_path = data.get("storage_path", None)
         upload_external_id = data.get("upload_external_id", None)
         url = None

upload/views/test_results.py

@@ -8,6 +8,7 @@
 from rest_framework.response import Response
 from rest_framework.views import APIView
 from shared.api_archive.archive import ArchiveService, MinioEndpoints
+from shared.events.amplitude import UNKNOWN_USER_OWNERID, AmplitudeEventPublisher
 from shared.metrics import inc_counter
 
 from codecov_auth.authentication.repo_auth import (
@@ -135,6 +136,20 @@ def post(self, request):
             },
         )
 
+        AmplitudeEventPublisher().publish(
+            "Upload Received",
+            {
+                "user_ownerid": commit.author.ownerid
+                if commit.author
+                else UNKNOWN_USER_OWNERID,
+                "ownerid": repo.author.ownerid,
+                "repoid": repo.repoid,
+                "commitid": commit.id,  # Not commit.commitid, we do not want a commit SHA here!
+                "pullid": commit.pullid,
+                "upload_type": "Test results",
+            },
+        )
+
         upload_external_id = str(uuid.uuid4())
 
         url = None

upload/views/upload_coverage.py

@@ -6,6 +6,7 @@
 from rest_framework.response import Response
 from rest_framework.views import APIView
 from shared.api_archive.archive import ArchiveService
+from shared.events.amplitude import UNKNOWN_USER_OWNERID, AmplitudeEventPublisher
 from shared.metrics import inc_counter
 
 from codecov_auth.authentication.repo_auth import (
@@ -92,6 +93,20 @@ def post(self, request: HttpRequest, *args, **kwargs) -> Response:
             ),
         )
 
+        AmplitudeEventPublisher().publish(
+            "Upload Received",
+            {
+                "user_ownerid": commit.author.ownerid
+                if commit.author
+                else UNKNOWN_USER_OWNERID,
+                "ownerid": commit.repository.author.ownerid,
+                "repoid": commit.repository.repoid,
+                "commitid": commit.id,  # Not commit.commitid, we do not want a commit SHA here.
+                "pullid": commit.pullid,
+                "upload_type": "Coverage report",
+            },
+        )
+
         # Create report
         commit_report_data = dict(
             code=request.data.get("code"),