Remove usage of additional Report.get arguments (#1210)

Author: Swatinem

graphql_api/tests/test_commit.py

@@ -90,7 +90,7 @@ def __init__(self):
 
 
 class MockReport(object):
-    def get(self, file, _else):
+    def get(self, filename):
         MockLines()
         return MockLines()
 
@@ -102,7 +102,7 @@ def get_flag_names(self):
 
 
 class EmptyReport(MockReport):
-    def get(self, file, _else):
+    def get(self, filename):
         return None
 
 

graphql_api/types/commit/commit.py

@@ -333,7 +333,7 @@ def resolve_coverage_flags(commit: Commit, info: GraphQLResolveInfo) -> list[str
 @commit_coverage_analytics_bindable.field("coverageFile")
 @sync_to_async
 def resolve_coverage_file(commit, info, path, flags=None, components=None):
-    _else, paths = None, []
+    fallback_file, paths = None, []
     if components:
         all_components = components_service.commit_components(
             commit, info.context["request"].current_owner
@@ -343,10 +343,10 @@ def resolve_coverage_file(commit, info, path, flags=None, components=None):
         )
         for fc in filtered_components:
             paths.extend(fc.paths)
-        _else = FilteredReportFile(ReportFile(path), [])
+        fallback_file = FilteredReportFile(ReportFile(path), [])
 
     commit_report = commit.full_report.filter(flags=flags, paths=paths)
-    file_report = commit_report.get(path, _else=_else)
+    file_report = commit_report.get(path) or fallback_file
 
     return {
         "commit_report": commit_report,