sec: remove open redirect to codecov (#799)

Author: ajay-sentry

codecov/tests/test_urls.py

@@ -3,18 +3,6 @@
 
 
 class ViewTest(TestCase):
-    def test_redirect_app(self):
-        client = Client()
-        response = client.get(
-            "/redirect_app/gh/codecov/codecov.io/settings", follow=False
-        )
-        self.assertRedirects(
-            response,
-            "http://localhost:3000/gh/codecov/codecov.io/settings",
-            302,
-            fetch_redirect_response=False,
-        )
-
     def test_health(self):
         client = Client()
         response = client.get("")

codecov/urls.py

@@ -34,7 +34,6 @@
         views.OwnerAutoCompleteSearch.as_view(),
         name="admin-owner-autocomplete",
     ),
-    re_path(r"^redirect_app", views.redirect_app),
     # /monitoring/metrics will be a public route unless you take steps at a
     # higher level to null-route or redirect it.
     path("monitoring/", include("django_prometheus.urls")),

codecov/views.py

@@ -1,7 +1,6 @@
 from dal import autocomplete
-from django.conf import settings
 from django.db import connection
-from django.http import HttpResponse, HttpResponseRedirect
+from django.http import HttpResponse
 
 from codecov_auth.models import Owner, Service
 from core.models import Constants, Repository
@@ -17,21 +16,13 @@ def _get_version():
 
 
 def health(request):
-    # will raise if connection cannot be estabilished
+    # will raise if connection cannot be established
     connection.ensure_connection()
 
     version = _get_version()
     return HttpResponse("%s is live!" % version.value)
 
 
-def redirect_app(request):
-    """
-    This view is intended to be used as part of the frontend migration to redirect traffic from legacy urls to urls
-    """
-    app_domain = settings.CODECOV_DASHBOARD_URL
-    return HttpResponseRedirect(app_domain + request.path.replace("/redirect_app", ""))
-
-
 SERVICE_CHOICES = dict(Service.choices)
 
 

graphs/helpers/badge.py

@@ -3,7 +3,7 @@
 from graphs.badges.badges import large_badge, medium_badge, small_badge, unknown_badge
 
 
-def get_badge(coverage, coverage_range, precision):
+def get_badge(coverage: str | None, coverage_range: list[int], precision: str):
     """
     Returns and SVG string containing coverage badge
 

graphs/views.py

@@ -121,7 +121,7 @@ def get_coverage(self):
 
     def flag_coverage(self, flag_name, commit):
         """
-        Looks into a commit's report sessions and returns the coverage for a perticular flag
+        Looks into a commit's report sessions and returns the coverage for a particular flag
 
         Parameters
         flag_name (string): name of flag