From a326f705afd9dee6b064193857b00f5b7eb8f444 Mon Sep 17 00:00:00 2001
From: Ben Webb <ben.webb@opendataservices.coop>
Date: Mon, 14 Nov 2022 14:51:26 +0000
Subject: [PATCH] Check refs to a publisher's own activities aren't counted

(in end to end traceability tests)

https://github.com/codeforIATI/IATI-Stats/issues/21
---
 .../data/funder2/funder2-activities.xml       | 34 +++++++++++++++++++
 traceable_percentages.csv.expected            |  2 +-
 2 files changed, 35 insertions(+), 1 deletion(-)

diff --git a/tests_end_to_end/fixtures/data/funder2/funder2-activities.xml b/tests_end_to_end/fixtures/data/funder2/funder2-activities.xml
index bcca9cffc3f..9b6e42ac458 100644
--- a/tests_end_to_end/fixtures/data/funder2/funder2-activities.xml
+++ b/tests_end_to_end/fixtures/data/funder2/funder2-activities.xml
@@ -14,6 +14,12 @@
             <transaction-date iso-date="2012-01-01" />
             <value currency="EUR">1000</value>
         </transaction>
+        <transaction>
+            <transaction-type code="1"/>
+            <transaction-date iso-date="2022-01-01" />
+            <value currency="GBP">1000</value>
+            <provider-org provider-activity-id="XE-EXAMPLE-BB-01" type="10" ref="XE-EXAMPLE-BB" />
+        </transaction>
     </iati-activity>
     <iati-activity>
         <iati-identifier>XE-EXAMPLE-CC-03</iati-identifier>
@@ -23,4 +29,32 @@
             <value currency="GBP">1000</value>
         </transaction>
     </iati-activity>
+    <iati-activity>
+        <iati-identifier>XE-EXAMPLE-CC-04</iati-identifier>
+        <transaction>
+            <transaction-type code="1"/>
+            <transaction-date iso-date="2022-01-01" />
+            <value currency="GBP">1000</value>
+            <provider-org provider-activity-id="XE-EXAMPLE-BB-01" type="10" ref="XE-EXAMPLE-BB" />
+        </transaction>
+        <transaction>
+            <transaction-type code="2"/>
+            <transaction-date iso-date="2022-01-01" />
+            <value currency="USD">1000</value>
+        </transaction>
+    </iati-activity>
+    <iati-activity>
+        <iati-identifier>XE-EXAMPLE-CC-05</iati-identifier>
+        <transaction>
+            <transaction-type code="1"/>
+            <transaction-date iso-date="2022-01-01" />
+            <value currency="GBP">1000</value>
+            <provider-org provider-activity-id="XE-EXAMPLE-CC-04" type="10" ref="XE-EXAMPLE-BB" />
+        </transaction>
+        <transaction>
+            <transaction-type code="2"/>
+            <transaction-date iso-date="2022-01-01" />
+            <value currency="USD">500</value>
+        </transaction>
+    </iati-activity>
 </iati-activities>
diff --git a/traceable_percentages.csv.expected b/traceable_percentages.csv.expected
index 18ce047fcb7..27c03cb370c 100644
--- a/traceable_percentages.csv.expected
+++ b/traceable_percentages.csv.expected
@@ -1,2 +1,2 @@
 funder,1,1,100.0,0,0,
-funder2,2,3,67,2284.4666822899517,3869.2116470760116,59
+funder2,2,5,40,2284.4666822899517,5369.211647076011,43