Skip to content

Booleans page should show truthy, falsy and invalid #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andylolz opened this issue Mar 25, 2021 · 1 comment
Open

Booleans page should show truthy, falsy and invalid #13

andylolz opened this issue Mar 25, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@andylolz
Copy link
Member

andylolz commented Mar 25, 2021

The dashboard boolean page lists False and True values alongside 0, 1, false and true. This is potentially confusing, since False and True (i.e. title case) are in fact invalid values according to the XML spec.

It might be better to either:

  1. ignore any values that are not 0, 1, false or true, or
  2. group invalid values as invalid.

This is exacerbated by the table column sort, which is case insensitive, so treats False and True as if they’re the same as false and true.

@andylolz andylolz added the bug Something isn't working label Mar 25, 2021
@andylolz andylolz added enhancement New feature or request and removed bug Something isn't working labels Apr 6, 2021
@andylolz andylolz changed the title False and True values are treated like they are valid booleans, when in fact they are not Booleans page should show truthy, falsy and invalid Apr 6, 2021
@andylolz
Copy link
Member Author

e06ba00 addresses the sort order issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant