Removed limitations for faq visibility

Author: powersurge360

app/controllers/state_file/faq_controller.rb

@@ -2,9 +2,7 @@ class StateFile::FaqController < ApplicationController
   layout "state_file"
 
   def index
-    years_to_show = filing_years_to_show # calculate once per request
     visible_state_code_names = StateFile::StateInformationService.state_code_to_name_map
-      .filter { |state_code, _| (years_to_show - StateFile::StateInformationService.filing_years(state_code)).empty? }
       .transform_values { |state_name| { state_name: } }
     visible_state_code_names.slice!(params[:us_state]) unless params[:us_state] == "us"
     product_types = visible_state_code_names.keys.map do |code|
@@ -20,10 +18,6 @@ def index
   end
 
   def show
-    if params[:us_state] == 'ny'
-      redirect_to state_landing_page_path(us_state: "ny")
-      return
-    end
     @section_key = params[:section_key]
     @faq_category = FaqCategory.find_by(slug: @section_key, product_type: FaqCategory.state_to_product_type(params[:us_state]))
 
@@ -32,6 +26,7 @@ def show
 
   private
 
+  # @deprecated FYST is retired now, show all categories all the time!
   def filing_years_to_show
     faq_show_start = Rails.configuration.state_file_show_faq_date_start
     faq_show_end = Rails.configuration.state_file_show_faq_date_end
@@ -48,12 +43,10 @@ def filing_years_to_show
         # show states that were open this year and will open next year
         [tax_year, tax_year + 1]
       end
+    elsif app_time > faq_show_end
+      [tax_year + 1]
     else
-      if app_time > faq_show_end
-        [tax_year + 1]
-      else
-        [tax_year]
-      end
+      [tax_year]
     end
   end
 end

config/application.rb

@@ -128,7 +128,7 @@ class Application < Rails::Application
     config.state_file_end_of_new_intakes = et.parse('2025-10-22 23:59:59')
     config.state_file_end_of_in_progress_intakes = et.parse('2025-10-31 23:59:59')
     config.state_file_show_faq_date_start = pt.parse('2024-12-10 00:00:00')
-    config.state_file_show_faq_date_end = pt.parse('2025-11-18 23:59:59')
+    config.state_file_show_faq_date_end = pt.parse('2025-11-15 23:59:59')
 
     config.allow_magic_verification_code = (Rails.env.demo? || Rails.env.development? || Rails.env.heroku? || Rails.env.staging?)
     config.allow_magic_ssn = (Rails.env.demo? || Rails.env.development? || Rails.env.heroku? || Rails.env.staging?)