state name look up is now language specfic

Author: Drew Proebstel

app/services/state_file/state_information_service.rb

@@ -42,9 +42,9 @@ class << self
         end
       end
 
-      def state_name(state_code)
+      def state_name(state_code, locale = I18n.locale)
         raise InvalidStateCodeError, state_code unless STATES_INFO.key?(state_code)
-        I18n.t("state_file.state_information_service.#{state_code}.state_name")
+        I18n.t("state_file.state_information_service.#{state_code}.state_name", locale: locale)
       end
 
       def department_of_taxation(state_code)
@@ -96,8 +96,11 @@ def active_state_codes
         @_active_state_codes ||= STATES_INFO.keys.map(&:to_s).freeze
       end
 
-      def state_code_to_name_map
-        @_state_code_to_name_map ||= active_state_codes.to_h { |state_code, _| [state_code, state_name(state_code)] }.freeze
+      def state_code_to_name_map(locale = I18n.locale)
+        @_state_code_to_name_map ||= {}
+        @_state_code_to_name_map[locale] ||= active_state_codes.to_h do |state_code|
+          [state_code, state_name(state_code, locale)]
+        end.freeze
       end
 
       def state_intake_classes

app/views/state_file/state_file_pages/about_page.html.erb

@@ -9,7 +9,7 @@
     <%= t(".closed_forever_subheader_html", faq_link: state_faq_path(us_state: 'us')) %>
   </div>
 
-  <%= link_to "https://pya.fileyourstatetaxes.org/#{I18n.locale}/year_select", class: "button button--primary button--home", id: "firstCta", role: "button", style: "display: flex; justify-content: center; align-items: center; text-align: center;"  do %>
+  <%= link_to "https://pya.fileyourstatetaxes.org/#{I18n.locale}/year_select", class: "button button--primary button--home no-external", id: "firstCta", role: "button", style: "display: flex; justify-content: center; align-items: center; text-align: center;"  do %>
     <%= t(".download_your_return") %>
   <% end %>
 

spec/services/state_file/state_information_service_spec.rb

@@ -8,28 +8,60 @@
   end
 
   describe ".state_code_to_name_map" do
-    it "returns a map of all the state codes to state names" do
-      result = {
-        "az" => "Arizona",
-        "md" => "Maryland",
-        "nc" => "North Carolina",
-        "nj" => "New Jersey",
-        "ny" => "New York",
-        "id" => "Idaho",
-      }
-      expect(described_class.state_code_to_name_map).to eq result
+    it "returns a map of all the state codes to state names in English by default" do
+      I18n.with_locale(:en) do
+        result = {
+          "az" => "Arizona",
+          "md" => "Maryland",
+          "nc" => "North Carolina",
+          "nj" => "New Jersey",
+          "ny" => "New York",
+          "id" => "Idaho",
+        }
+
+        expect(described_class.state_code_to_name_map).to eq(result)
+      end
+    end
+
+    it "is locale aware and returns localized state names for the current locale" do
+      I18n.with_locale(:es) do
+        result = {
+          "az" => I18n.t("state_file.state_information_service.az.state_name"),
+          "md" => I18n.t("state_file.state_information_service.md.state_name"),
+          "nc" => I18n.t("state_file.state_information_service.nc.state_name"),
+          "nj" => I18n.t("state_file.state_information_service.nj.state_name"),
+          "ny" => I18n.t("state_file.state_information_service.ny.state_name"),
+          "id" => I18n.t("state_file.state_information_service.id.state_name"),
+        }
+
+        expect(described_class.state_code_to_name_map).to eq(result)
+      end
     end
   end
 
   describe ".state_intake_classes" do
     it "returns an array of the intake classes" do
-      expect(described_class.state_intake_classes).to match_array [StateFileAzIntake, StateFileIdIntake, StateFileMdIntake, StateFileNcIntake, StateFileNjIntake, StateFileNyIntake]
+      expect(described_class.state_intake_classes).to match_array [
+                                                                    StateFileAzIntake,
+                                                                    StateFileIdIntake,
+                                                                    StateFileMdIntake,
+                                                                    StateFileNcIntake,
+                                                                    StateFileNjIntake,
+                                                                    StateFileNyIntake,
+                                                                  ]
     end
   end
 
   describe ".state_intake_class_names" do
     it "returns an array of the intake classes as strings" do
-      expect(described_class.state_intake_class_names).to match_array ["StateFileAzIntake", "StateFileIdIntake", "StateFileMdIntake", "StateFileNcIntake", "StateFileNjIntake", "StateFileNyIntake"]
+      expect(described_class.state_intake_class_names).to match_array [
+                                                                        "StateFileAzIntake",
+                                                                        "StateFileIdIntake",
+                                                                        "StateFileMdIntake",
+                                                                        "StateFileNcIntake",
+                                                                        "StateFileNjIntake",
+                                                                        "StateFileNyIntake",
+                                                                      ]
     end
   end