Skip to content

Commit 3b943ba

Browse files
committed
fix the tagg in note email
1 parent 0fe050f commit 3b943ba

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

app/services/interaction_tracking_service.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def self.record_internal_interaction(client, **attrs)
4545

4646
if interaction_type == "tagged_in_note"
4747
user = attrs[:user]
48-
if user&.tagged_in_note_notification_yes? && Flipper.enabled?(:hub_email_notifications)
48+
if user&.tagged_in_note_notification_yes? && Flipper.enabled?(:hub_email_notifications) && user&.active?
4949
internal_email = InternalEmail.create!(
5050
mail_class: UserMailer,
5151
mail_method: :internal_interaction_notification_email,

spec/services/interaction_tracking_service_spec.rb

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,15 @@
225225
expect(SendInternalEmailJob).not_to have_received(:perform_later)
226226
end
227227
end
228+
229+
context "user has been suspended" do
230+
let(:user) { create(:admin_user, tagged_in_note_notification: "yes", suspended_at: 1.day.ago) }
231+
232+
it "doesn't send a message" do
233+
described_class.record_internal_interaction(client, interaction_type: "tagged_in_note", user: user, received_at: received_at)
234+
expect(SendInternalEmailJob).not_to have_received(:perform_later)
235+
end
236+
end
228237
end
229238
end
230239
end

0 commit comments

Comments
 (0)