Fix routing logic

Author: tahsinaislam

app/services/partner_routing_service.rb

@@ -103,7 +103,8 @@ def vita_partner_from_zip_code
 
     eligible_with_capacity = Organization.with_capacity.joins(:serviced_zip_codes).
       where(vita_partner_zip_codes: { zip_code: @zip_code })
-    vita_partner = eligible_with_capacity.first
+
+    vita_partner = eligible_with_capacity.order(Arel.sql('RANDOM()')).first
 
     if vita_partner.present?
       @routing_method = :zip_code

spec/forms/hub/zip_code_routing_form_spec.rb

@@ -11,32 +11,6 @@
     }
   end
   describe "#valid?" do
-    context "when the zip code is already in use" do
-      context "when it belongs to current vita partner" do
-        before do
-          create :vita_partner_zip_code, vita_partner: vita_partner, zip_code: zip_code
-        end
-
-        it "is invalid with appropriate message" do
-          expect(subject.valid?).to eq false
-          expect(subject.errors[:zip_code]).to include "94606 is already routed to this partner."
-        end
-      end
-
-      context "when it belongs to a different vita partner" do
-        let(:other_vita_partner) { create :organization, name: "Oregano Org" }
-        before do
-          create :vita_partner_zip_code, vita_partner: other_vita_partner, zip_code: zip_code
-        end
-
-        it "is invalid with appropriate message" do
-          expect(subject.valid?).to eq false
-          expect(subject.errors[:zip_code]).to include "94606 is already routed to <a href=/en/hub/organizations/#{other_vita_partner.id}/edit#zip-code-routing-form>Oregano Org</a>."
-        end
-      end
-
-    end
-
     context "when the zip code is not valid" do
       let(:zip_code) { "A2345"}
       it "is invalid" do

spec/services/partner_routing_service_spec.rb

@@ -359,5 +359,32 @@
         end
       end
     end
+
+    context "when multiple Vita Partners serve the same zip code" do
+      let(:vita_partner_2) { create :organization, name: "Partner 2" }
+      before do
+        create :vita_partner_zip_code, zip_code: "94606", vita_partner: vita_partner_2
+      end
+
+      subject { PartnerRoutingService.new(zip_code: "94606") }
+
+      it "routes to one of the partners with capacity" do
+        result = subject.determine_partner
+
+        expect([vita_partner, vita_partner_2]).to include(result)
+        expect(subject.routing_method).to eq :zip_code
+      end
+
+      context "when one partner is at capacity" do
+        before do
+          vita_partner.update(capacity_limit: 0)
+        end
+
+        it "routes only to partners with capacity" do
+          expect(subject.determine_partner).to eq vita_partner_2
+          expect(subject.routing_method).to eq :zip_code
+        end
+      end
+    end
   end
 end