Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consumer] Can't view an event in mobile. #104

Open
aaronsalmon opened this issue Jul 1, 2016 · 6 comments
Open

[Consumer] Can't view an event in mobile. #104

aaronsalmon opened this issue Jul 1, 2016 · 6 comments
Labels
Milestone

Comments

@aaronsalmon
Copy link
Member

when on your phone:

  1. navigate to a date that has an event pin
  2. click the pin to open the popup.

the popup flashes open for a moment and closes/disappears.

@aaronsalmon aaronsalmon added the bug label Jul 1, 2016
@aaronsalmon aaronsalmon changed the title Can't view an event in mobile. [consumer UI] Can't view an event in mobile. Jul 1, 2016
@aaronsalmon aaronsalmon changed the title [consumer UI] Can't view an event in mobile. [Consumer] Can't view an event in mobile. Jul 1, 2016
@AnthonyAstige AnthonyAstige added this to the v0.1 - MVP milestone Jul 1, 2016
@aaronsalmon
Copy link
Member Author

this is the highest priority issue I found so far. currently unusable on a phone.

@AnthonyAstige
Copy link
Member

AnthonyAstige commented Jul 1, 2016

Reproducible on desktop by making a very short browser window. Roughly speaking it looks like if the title + image don't fit on screen, the popup auto-closes.

@levifelling
Copy link
Contributor

From what I can tell the marker click event attempts to pan the map such that the popup is visible, but because the popup window is too large to fit on the screen it pans the marker off the visible map, which is triggering the close popup event.

options:

  1. switch from popup to modal dialog (fixed size & location)
  2. fix popup size, add inner scrollbars for overflow content

other ideas?

@AnthonyAstige
Copy link
Member

@levifelling Ah good explanation, that sounds very likely the cause

option (I'm not sure if this is easily possible):
4. Make auto closing trigger less aggressive (it appears the pin can be off the map a little before closing already, but we need it further).

option (Though I think bad):
3. Disable auto-pan

@levifelling
Copy link
Contributor

added maxHeight constraint to popup 22cda99

@AnthonyAstige
Copy link
Member

RE - 22cda99

  1. Edge case: when resizing the browser window from large to small, original bug still appears (as height is only calculated at start)
  2. Math of screen size / 3 is a bit oversimplistic not using all available space (see screenshot below)

screenshot from 2016-07-01 16-35-09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants