Updates to test and PR workflows

Signed-off-by: worksofliam <mrliamallan@live.co.uk>

Author: worksofliam

.github/workflows/pr.yaml

@@ -39,6 +39,7 @@ jobs:
 
       - name: Post comment
         if: steps.fc.outputs.comment-id == '' && always()
+        continue-on-error: true
         uses: actions/github-script@v5
         with:
           script: |
@@ -51,6 +52,7 @@ jobs:
 
       - name: Update comment
         if: steps.fc.outputs.comment-id != '' && always()
+        continue-on-error: true
         uses: peter-evans/create-or-update-comment@v1
         with:
           edit-mode: replace

.github/workflows/test.yaml

@@ -21,7 +21,13 @@ jobs:
         with:
           node-version: 18
       - run: npm ci
-      - run: npm run test
+
+      - name: Type checker
+        run: npm run typings
+
+      # This step won't run when coming from a fork
+      - name: Test suite
+        run: npm run test
         if: contains(env.VITE_SERVER, '.')
         env:
           VITE_SERVER: ${{ secrets.VITE_SERVER }}

src/api/tests/connection.ts

@@ -14,12 +14,31 @@ const testConfig = new JsonConfig();
 export const CONNECTION_TIMEOUT = process.env.VITE_CONNECTION_TIMEOUT ? parseInt(process.env.VITE_CONNECTION_TIMEOUT) : 25000;
 
 const ENV_CREDS = {
-  host: process.env.VITE_SERVER || `localhost`,
+  host: process.env.VITE_SERVER,
   user: process.env.VITE_DB_USER,
   password: process.env.VITE_DB_PASS,
   port: parseInt(process.env.VITE_DB_PORT || `22`)
 }
 
+if (ENV_CREDS.host === undefined) {
+  const messages = [
+    ``,
+    `Please set the environment variables:`,
+    `\tVITE_SERVER`,
+    `\tVITE_DB_USER`,
+    `\tVITE_DB_PASS`,
+    `\tVITE_DB_PORT`,
+    ``,
+    `If you're a developer, make a copy of .env.sample,`,
+    `rename it to .env, and set the values.`,
+    ``,
+  ];
+
+  console.log(messages.join(`\n`));
+
+  process.exit(1);
+}
+
 export async function newConnection() {
   const virtualStorage = testStorage;