Skip to content

Commit 4f47288

Browse files
committed
Moved readyTimeout field to the bottom
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
1 parent 7bc8b3e commit 4f47288

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/webviews/login/index.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,13 @@ export class Login {
2929
.addInput(`host`, l10n.t(`Host or IP Address`), undefined, { minlength: 1 })
3030
.addInput(`port`, l10n.t(`Port (SSH)`), ``, { default: `22`, minlength: 1, maxlength: 5, regexTest: `^\\d+$` })
3131
.addInput(`username`, l10n.t(`Username`), undefined, { minlength: 1, maxlength: 10 })
32-
.addInput(`readyTimeout`, l10n.t(`Connection Timeout (in milliseconds)`), l10n.t(`How long to wait for the SSH handshake to complete.`), { inputType: "number", min: 1, default: "20000" })
3332
.addHorizontalRule()
3433
.addParagraph(l10n.t(`Only provide either the password or a private key - not both.`))
3534
.addPassword(`password`, l10n.t(`Password`))
3635
.addCheckbox(`savePassword`, l10n.t(`Save Password`))
37-
.addFile(`privateKeyPath`, l10n.t(`Private Key`), l10n.t(`OpenSSH, RFC4716, or PPK formats are supported.`));
36+
.addFile(`privateKeyPath`, l10n.t(`Private Key`), l10n.t(`OpenSSH, RFC4716, or PPK formats are supported.`))
37+
.addHorizontalRule()
38+
.addInput(`readyTimeout`, l10n.t(`Connection Timeout (in milliseconds)`), l10n.t(`How long to wait for the SSH handshake to complete.`), { inputType: "number", min: 1, default: "20000" });
3839

3940
const tempTab = new Section()
4041
.addInput(`tempLibrary`, `Temporary library`, `Temporary library. Cannot be QTEMP.`, { default: `ILEDITOR`, minlength: 1, maxlength: 10 })

src/webviews/settings/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,11 +362,12 @@ export class SettingsUI {
362362
.addInput(`host`, vscode.l10n.t(`Host or IP Address`), undefined, { default: stored.host, minlength: 1 })
363363
.addInput(`port`, vscode.l10n.t(`Port (SSH)`), undefined, { default: String(stored.port), minlength: 1, maxlength: 5, regexTest: `^\\d+$` })
364364
.addInput(`username`, vscode.l10n.t(`Username`), undefined, { default: stored.username, minlength: 1 })
365-
.addInput(`readyTimeout`, vscode.l10n.t(`Connection Timeout (in milliseconds)`), vscode.l10n.t(`How long to wait for the SSH handshake to complete.`), { inputType: "number", min: 1, default: stored.readyTimeout ? String(stored.readyTimeout) : "20000" })
366365
.addHorizontalRule()
367366
.addParagraph(vscode.l10n.t(`Only provide either the password or a private key - not both.`))
368367
.addPassword(`password`, `${vscode.l10n.t(`Password`)}${storedPassword ? ` (${vscode.l10n.t(`stored`)})` : ``}`, vscode.l10n.t("Only provide a password if you want to update an existing one or set a new one."))
369368
.addFile(`privateKeyPath`, `${vscode.l10n.t(`Private Key`)}${privateKeyPath ? ` (${vscode.l10n.t(`Private Key`)}: ${privateKeyPath})` : ``}`, privateKeyWarning + vscode.l10n.t("Only provide a private key if you want to update from the existing one or set one.") + '<br />' + vscode.l10n.t("OpenSSH, RFC4716 and PPK formats are supported."))
369+
.addHorizontalRule()
370+
.addInput(`readyTimeout`, vscode.l10n.t(`Connection Timeout (in milliseconds)`), vscode.l10n.t(`How long to wait for the SSH handshake to complete.`), { inputType: "number", min: 1, default: stored.readyTimeout ? String(stored.readyTimeout) : "20000" })
370371
.addButtons(
371372
{ id: `submitButton`, label: vscode.l10n.t(`Save`), requiresValidation: true },
372373
{ id: `removeAuth`, label: vscode.l10n.t(`Remove auth methods`) }

0 commit comments

Comments
 (0)