-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On one IBMi I can't open a source member with '£' in the member's name, but on another one it works #2519
Comments
Thanks for sending the logs. Any chance you can send the entire log after connecting and reloading? (Right click on your server -> connect and reload) |
Sure. |
I have done some tests connected via ssh. -bash-5.2$ /usr/bin/attr -p /QSYS.LIB/W_BENMAR.LIB/SRC.FILE/A#UTX26.MBR CREATE_TIME MODIFY_TIME DATA_SIZE with £ in the member name it works. But if I get the list of the source file content, I get member names with #. |
I tried with version 2.13.0 and it works. |
Well the good news is that CCSIDs are working as expected and I know that because of the output in the logs: ✅
And I can see the list is showing the pound sign correctly in the result set: ✅
But it's going wrong when we are fetching the attributes of this file: ❌
But funnily enough does fetch the member correctly! ✅
@sebjulliand didn't you make a new change/fix to getAttributes recently? Maybe this has to do with the fact that we're passing in the system variant to
@benetti-smeup did show the
I am seeing a lot of |
@worksofliam that's weird...I can work with members in CCSID 297 with variants without problems. |
Same problem with the pre-release. |
@worksofliam on my CCSID 297 LPAR too, attr receives the american variants: /home/SJULLIAND: /home/SJULLIAND/.vscode/cqsh_1
/usr/bin/attr -p /QSYS.LIB/@MAZING.LIB/[email protected]/H@L@#@\$.MBR CREATE_TIME MODIFY_TIME DATA_SIZE
{
"code": 0,
"signal": null,
"stdout": "DATA_SIZE=306\nCREATE_TIME=Fri Nov 15 23:46:57 2024\nMODIFY_TIME=Fri Nov 15 23:47:00 2024",
"stderr": ""
} The same kind of call on @benetti-smeup's LPAR returns an error /home/BENMAR: /home/BENMAR/.vscode/cqsh_1
/usr/bin/attr -p /QSYS.LIB/W_BENMAR.LIB/SRC.FILE/A#UTX26.MBR CREATE_TIME MODIFY_TIME DATA_SIZE
{
"code": 1,
"signal": null,
"stdout": "",
"stderr": "attr: 001-2248 Errore rilevato nell'ottenere gli attributi per il file /QSYS.LIB/W_BENMAR.LIB/SRC.FILE/A#UTX26.MBR. Questo percorso o indirizzario non esiste."
} Infact, in the first post, we see calls on both working and not working LPAR are of the same kind. The only difference is that QCCSID is undefined where it works, and set to @benetti-smeup , sorry to ask you to go through all these hoops and loops, but, can you check if it works with |
@sebjulliand |
Which means you can't list these members on either LPAR with 2.13.0? |
Precisely. |
@sebjulliand @benetti-smeup I am not 100% following with Macro's responses. So you can't open the member in either 2.13.0 or 2.14.5? |
Using 2.13.0 i can open the member with CTR+ALT+P but i can't list members of a source file with a name that contains '£' using object browser. |
Is there any other test I can do to help understand the issue? |
I tried with v.2.15.0 and I have the same issue. |
@benetti-smeup There is a chance that #2546 may solve the issue, and a new release will be out with that shortly. The Possibly here where the bug is happening (No |
@benetti-smeup 2.15.1 is out now. Give that a try! |
I tried with v.2.15.1 but I have the same issue. |
@SanjulaGanepola and I have been looking into this. Are you able to share the steps of how you created a member with a Additionally: if they were created in a green screen, what CCSID is the client session setup with? |
In a 5250 session (client ccsid 1144, job ccsid 1144, default ccsid 1144) CRTSRCPF FILE(W_BENMAR/SRCTST1) CCSID(1144) I can create source files with '£', too |
@benetti-smeup Is it still the case that it works on one system and not the other? |
Yes. |
@benetti-smeup on the system that does not work, can you try and create a member with the name that works on the other system?
|
Done. Same problem. |
@benetti-smeup What happens if you run the command from a shell manually? Preferably bash. /usr/bin/attr -p /QSYS.LIB/W_BENMAR.LIB/SRCTST1.FILE/A#_159_A1.MBR CREATE_TIME MODIFY_TIME DATA_SIZE |
but using '£' instead of '#' |
sure. only connect and realod or try to open the member too? |
@benetti-smeup Just connect and reload should be enough as it will return some information I am looking for. |
@benetti-smeup Sadly that's not quite right. I need the log directly after you connect and reload please. Looks like those logs had some lists in them. |
Alrighty, I think I've come to a conclusion on the issue. Your job CCSID and SSHD CCSID match, so it's likely we don't need to convert in that instance. I will keep you posted. |
Thanks! |
@benetti-smeup Please try the build here: #2556 |
This build works on the system that previously didn't work (ccsid 1144/1144), but doesn't work on the system that previously worked (280/65535). In the output on system (280/65535) I see
instead of
|
@benetti-smeup Can you please send the logs after a connect and reload of the system that is not working? Thanks! |
Here the output. |
@benetti-smeup A brand new build is available, please try it out: |
with this version on the system (280/65535) is much slower listing the members and trying to open a member with '£' it seems to be in a loop. |
@SanjulaGanepola could this be your error ^ appearing again? |
Yup. Let me put that specific change right now into a branch and if it looks good, maybe merge into main or your branch? |
@benetti-smeup Another new build is ready for you: |
Now on the system (1144/1144) I can open members with '£' and members of source files with '£' and I can list members of source files with '£'. |
Any chance you can explain this a little more? I don't understand. At first you say you can open, and then you can't? Cheers! |
On the system (280/65535) i can open W_BENMAR/SRC/A£ _159_A1.RPGLE but I can't open W_BENMAR/£UI_SRC/A£ _159_A1.RPGLE or W_BENMAR/£UI_SRC/AUTLIB.RPGLE. |
@benetti-smeup Can you please share the output logs of those happening? Thanks!! |
@benetti-smeup Yet another new build is ready for you to try: #2556 (comment) Thanks! |
/home/BENMAR: LC_ALL=EN_US.UTF-8 /home/BENMAR/.vscode/cqsh_1 -c "system "call QSYS/QZDFMDB2 PARM('-d' '-i' '-t')"" /home/BENMAR: LC_ALL=EN_US.UTF-8 /home/BENMAR/.vscode/cqsh_1 -c "system "call QSYS/QZDFMDB2 PARM('-d' '-i' '-t')"" { |
Same issue. |
@benetti-smeup I will need more logs please for the errors. Your last comment didn't have any. |
Here the log. |
@benetti-smeup A new build is available for you here: #2556 (comment) |
@worksofliam |
@benetti-smeup no, sadly we have to clear them oversize VS Code slows down. I'm actually leaving after today for a week holiday, so hopefully someone else can step up in my absence, though no promises. There are two options for this issue:
|
Describe the bug
I can't open members with a name that cointans '£'.
We use the extension on two IBM i systems, and it works correctly on one but not on the other.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Screenshots
Environment in which the error occurs
Extension version v2.14.5
RPGLE language tools v0.28.6
IBM i OS version 7.4
db2util 1.0.12-1
usrprf
LANGID *SYSVAL
CNTRYID *SYSVAL
CCSID *SYSVAL
wrksysval
QCCSID 1144
QCNTRYID IT
QLANGID ITA
QCHRID 695-1144
WRKENVVAR LEVEL(*SYS)
PASE_LANG 'IT_IT'
QIBM_PASE_CCSID '1208'
Output
/home/BENMAR: /home/BENMAR/.vscode/cqsh_1 -c "system "call QSYS/QZDFMDB2 PARM('-d' '-i' '-t')""
Call QSYS2.QCMDEXC('CHGJOB CCSID(280)');
CREATE OR REPLACE ALIAS W_BENMARVS.TEMP_14ABC61BA512EA10E29B0B7958C12F89A62DF577 for "W_BENMAR"."SRC"("A£UTX26")
/home/BENMAR: /home/BENMAR/.vscode/cqsh_1
/usr/bin/attr -p /QSYS.LIB/W_BENMAR.LIB/SRC.FILE/A#UTX26.MBR CREATE_TIME MODIFY_TIME DATA_SIZE
{
"code": 1,
"signal": null,
"stdout": "",
"stderr": "attr: 001-2248 Errore rilevato nell'ottenere gli attributi per il file /QSYS.LIB/W_BENMAR.LIB/SRC.FILE/A#UTX26.MBR. Questo percorso o indirizzario non esiste."
}
Environment in which the extension works
Extension version v2.14.5
RPGLE language tools v0.28.6
IBM i OS version 7.5
db2util 1.0.12-1
usrprf
LANGID *SYSVAL
CNTRYID *SYSVAL
CCSID *SYSVAL
wrksysval
QCCSID 65535
QCNTRYID IT
QLANGID ITA
QCHRID 697-280
WRKENVVAR LEVEL(*SYS)
PASE_LANG 'IT_IT'
QIBM_PASE_CCSID '1208'
Output
/home/BENMAR: /home/BENMAR/.vscode/cqsh_1 -c "system "call QSYS/QZDFMDB2 PARM('-d' '-i' '-t')""
Call QSYS2.QCMDEXC('CHGJOB CCSID(280)');
CREATE OR REPLACE ALIAS W_BENMARVS.TEMP_220535EAC6C3441BB23B646BF1D2ADF1796AE358 for "W_BENMAR"."SRC"("A£_159_A1")
/home/BENMAR: /home/BENMAR/.vscode/cqsh_1
/usr/bin/attr -p /QSYS.LIB/W_BENMAR.LIB/SRC.FILE/A#_159_A1.MBR CREATE_TIME MODIFY_TIME DATA_SIZE
{
"code": 0,
"signal": null,
"stdout": "DATA_SIZE=48858\nCREATE_TIME=Wed May 1 12:00:10 2024\nMODIFY_TIME=Wed May 1 20:38:30 2024",
"stderr": ""
}
The text was updated successfully, but these errors were encountered: