Saas 4622 (#38)

* add firebase health check

Author: oren-codefresh

Diff for: lib/index.js

@@ -25,3 +25,22 @@ const logger = new Logger({
 
 logger.validate();
 logger.start();
+
+process.on('beforeExit', (code) => {
+    logger.state.beforeExitCode = code;
+    logger._writeNewState();
+});
+process.on('exit', (code) => {
+    logger.state.exitCode = code;
+    logger._writeNewState();
+});
+
+process.on('uncaughtException', (error) => {
+    logger.state.uncaughtException = error;
+    logger._writeNewState();
+});
+
+process.on('unhandledRejection', (reason) => {
+    logger.state.unhandledRejection = reason;
+    logger._writeNewState();
+});

Diff for: lib/logger.js

@@ -20,7 +20,7 @@ class Logger {
         findExistingContainers,
         logSizeLimit
     }) {
-        this.state                  = { status: 'init', lastLogsDate: Date.now() };
+        this.state                  = { status: 'init', lastLogsDate: Date.now() , failedHealthChecks: [] };
         this.taskLoggerConfig       = taskLoggerConfig;
         this.loggerId               = loggerId;
         this.findExistingContainers = findExistingContainers === 'true';
@@ -71,6 +71,16 @@ class Logger {
                 taskLogger.on('error', (err) => {
                     logger.error(err.stack);
                 });
+                taskLogger.startHealthCheck();
+                taskLogger.onHealthCheckReported((status) => {
+                    if (status.status === 'failed') {
+                        this.state.failedHealthChecks.push(status);
+                        this.state.status = 'failed';
+                    }else {
+                        this.state.healthCheckStatus = status; 
+                    }
+                    this._writeNewState();
+                });
 
                 this.taskLogger = taskLogger;
                 logger.info(`taskLogger successfully created`);

Diff for: package.json

@@ -6,7 +6,7 @@
     "cf-container-logger"
   ],
   "dependencies": {
-    "@codefresh-io/task-logger": "1.5.7",
+    "@codefresh-io/task-logger": "1.5.9",
     "cf-errors": "^0.1.11",
     "cf-logs": "^1.1.0",
     "docker-events": "0.0.2",

Diff for: service.yaml

@@ -1 +1 @@
-version: 1.2.0
+version: 1.2.1

Diff for: test/logger.unit.spec.js

@@ -74,7 +74,9 @@ describe('Logger tests', () => {
             it('should start and not listen for existing container in case findExistingContainers param is false', async () => { // jshint ignore:line
                 const taskLogger        = { // jshint ignore:line
                     on: sinon.spy(),
-                    restore: sinon.spy(() => Q.resolve())
+                    restore: sinon.spy(() => Q.resolve()),
+                    startHealthCheck: sinon.spy(),
+                    onHealthCheckReported: sinon.spy(),
                 };
                 const TaskLoggerFactory = sinon.spy(() => {
                     return Q.resolve(taskLogger);
@@ -106,11 +108,99 @@ describe('Logger tests', () => {
 
             });
 
+            it('should report health check status if failed', async () => { // jshint ignore:line
+                let onHealthCheckReportedCb;
+                const onHealthCheckReportedSpy = sinon.spy((func) =>  {
+                    onHealthCheckReportedCb = func;
+                });
+
+                const taskLogger        = { // jshint ignore:line
+                    on: sinon.spy(),
+                    restore: sinon.spy(() => Q.resolve()),
+                    startHealthCheck: sinon.spy(),
+                    onHealthCheckReported: onHealthCheckReportedSpy,
+                };
+                const TaskLoggerFactory = sinon.spy(() => {
+                    return Q.resolve(taskLogger);
+                });
+
+                const Logger = proxyquire('../lib/logger', {
+                    '@codefresh-io/task-logger': { TaskLogger: TaskLoggerFactory }
+                });
+
+                const loggerId               = 'loggerId';
+                const taskLoggerConfig = {task: {}, opts: {}};
+                const findExistingContainers = false;
+
+                const logger                        = new Logger({
+                    loggerId,
+                    taskLoggerConfig,
+                    findExistingContainers,
+                });
+                logger._listenForNewContainers      = sinon.spy();
+                logger._writeNewState               = sinon.spy();
+                logger._listenForExistingContainers = sinon.spy();
+                logger.start();
+                
+
+                await Q.delay(10);
+                onHealthCheckReportedCb({status: 'failed'});
+                
+                expect(taskLogger.startHealthCheck).to.be.calledOnce;
+                expect(logger.state.failedHealthChecks.length).to.be.equals(1);
+
+            });
+
+            it('should report health check status if succeed', async () => { // jshint ignore:line
+                let onHealthCheckReportedCb;
+                const onHealthCheckReportedSpy = sinon.spy((func) =>  {
+                    onHealthCheckReportedCb = func;
+                });
+
+                const taskLogger        = { // jshint ignore:line
+                    on: sinon.spy(),
+                    restore: sinon.spy(() => Q.resolve()),
+                    startHealthCheck: sinon.spy(),
+                    onHealthCheckReported: onHealthCheckReportedSpy,
+                };
+                const TaskLoggerFactory = sinon.spy(() => {
+                    return Q.resolve(taskLogger);
+                });
+
+                const Logger = proxyquire('../lib/logger', {
+                    '@codefresh-io/task-logger': { TaskLogger: TaskLoggerFactory }
+                });
+
+                const loggerId               = 'loggerId';
+                const taskLoggerConfig = {task: {}, opts: {}};
+                const findExistingContainers = false;
+
+                const logger                        = new Logger({
+                    loggerId,
+                    taskLoggerConfig,
+                    findExistingContainers,
+                });
+                logger._listenForNewContainers      = sinon.spy();
+                logger._writeNewState               = sinon.spy();
+                logger._listenForExistingContainers = sinon.spy();
+                logger.start();
+                
+
+                await Q.delay(10);
+                onHealthCheckReportedCb({status: 'succeed'});
+                
+                expect(taskLogger.startHealthCheck).to.be.calledOnce;
+                expect(logger.state.healthCheckStatus).to.deep.equal({status: 'succeed'});
+
+            });
+
             it('should start and listen for existing container in case findExistingContainers param is "true"', async () => {
 
                 const taskLogger        = {
                     on: sinon.spy(),
-                    restore: sinon.spy(() => Q.resolve())
+                    restore: sinon.spy(() => Q.resolve()),
+                    startHealthCheck: sinon.spy(),
+                    onHealthCheckReported: sinon.spy(),
                 };
                 const TaskLoggerFactory = sinon.spy(() => {
                     return Q.resolve(taskLogger);

Diff for: yarn.lock

@@ -2,10 +2,10 @@
 # yarn lockfile v1
 
 
-"@codefresh-io/[email protected].7":
-  version "1.5.7"
-  resolved "https://registry.yarnpkg.com/@codefresh-io/task-logger/-/task-logger-1.5.7.tgz#0871391247dfffdf47e61daca1e7c0822ae1aa8d"
-  integrity sha512-F3NWmjsD9eAJm/2uEpDfb9y8uxZktqtD1kTGLO85OeDdmspqT9szI4ZhcKwduz8yuuPidy5Ayz4zlcFRQEBxBQ==
+"@codefresh-io/[email protected].9":
+  version "1.5.9"
+  resolved "https://registry.yarnpkg.com/@codefresh-io/task-logger/-/task-logger-1.5.9.tgz#de59799634a02fe616be23daf591adca6d0fac5b"
+  integrity sha512-FqjK5qniqiYSyWI9SMwa35qPumuI7qgDK26UhJfnjeFuOdRu1aDP+/J9wXG1oBNGKlighxGU8oRT3+thnOc3sQ==
   dependencies:
     cf-errors "^0.1.11"
     crypto "0.0.3"