feat: system runtimes in git

Author: mikhail-klimko

charts/cf-runtime/Chart.yaml

@@ -18,7 +18,15 @@ annotations:
   # Supported kinds: `added`, `changed`, `deprecated`, `removed`, `fixed`, `security`:
   artifacthub.io/changes: |
     - kind: changed
-      description: "Fix kubeconfigFilePath for agentless runtime"
+      description: "(on-premise) Fix kubeconfigFilePath for agentless runtime"
+    - kind: added
+      description: "(on-premise) Add option to create extra agentless runtimes"
+    - kind: added
+      description: "Add cronjob to constantle patch runtime spec"
+    - kind: fixed
+      description: "Fix missing codefresh-dind-config ConfigMap in runtime spec"
+    - kind: changed
+      description: "Misc templates renaming"
 dependencies:
   - name: cf-common
     repository: oci://quay.io/codefresh/charts

charts/cf-runtime/files/patch-runtime.sh

@@ -14,41 +14,37 @@ else
     patch_type="sys-re"
 fi
 
+modify_accounts() {
+    local runtime_name_encoded
+    runtime_name_encoded=$(yq '.metadata.name' "$1" | jq -r @uri)
+    local accounts
+    accounts=$(yq '.accounts' "$1")
+
+    if [[ -n $accounts ]]; then
+        local payload
+        payload=$(echo "$accounts" | jq '{accounts: .}')
+        set +x
+        curl -X PUT \
+            -H "Content-Type: application/json" \
+            -H "Authorization: $API_KEY" \
+            -d "$payload" \
+            "$API_HOST/api/admin/runtime-environments/account/modify/$runtime_name_encoded"
+    else
+        echo "No accounts to add for $1"
+    fi
+}
+
 for runtime in /opt/codefresh/*.yaml; do
     if [[ -f $runtime ]]; then
         codefresh patch $patch_type -f $runtime
-        ACCOUNTS=$(yq '.accounts' $runtime)
-        RUNTIME_NAME_ENCODED=$(yq '.metadata.name' $runtime | jq -r @uri)
-        if [[ -n $ACCOUNTS ]]; then
-            PAYLOAD=$(echo $ACCOUNTS | jq '{accounts: .}')
-                set +x
-                curl -X PUT \
-                    -H "Content-Type: application/json" \
-                    -H "Authorization: $API_KEY" \
-                    -d "$PAYLOAD" \
-                    "$API_HOST/api/admin/runtime-environments/account/modify/$RUNTIME_NAME_ENCODED"
-        else
-            echo "No accounts to add"
-        fi
+        modify_accounts "$runtime"
     fi
 done
 
 for runtime in /opt/codefresh/runtime.d/system/*.yaml; do
     if [[ -f $runtime ]]; then
         cat $runtime
         codefresh patch sys-re -f $runtime
-        ACCOUNTS=$(yq '.accounts' $runtime)
-        RUNTIME_NAME_ENCODED=$(yq '.metadata.name' $runtime | jq -r @uri)
-        if [[ -n $ACCOUNTS ]]; then
-            PAYLOAD=$(echo $ACCOUNTS | jq '{accounts: .}')
-                set +x
-                curl -X PUT \
-                    -H "Content-Type: application/json" \
-                    -H "Authorization: $API_KEY" \
-                    -d "$PAYLOAD" \
-                    "$API_HOST/api/admin/runtime-environments/account/modify/$RUNTIME_NAME_ENCODED"
-        else
-            echo "No accounts to add"
-        fi
+        modify_accounts "$runtime"
     fi
 done

charts/cf-runtime/tests/private-registry/private_registry_test.yaml

@@ -114,8 +114,8 @@ tests:
                   name: codefresh-certs-server
                   mountPath: /etc/ssl/cf
                   readOnly: true
-                codefresh-dind-config:
-                  name: codefresh-dind-config
+                dind-config:
+                  name: dind-config
                   mountPath: /etc/docker/daemon.json
                   subPath: daemon.json
                   readOnly: true
@@ -124,8 +124,8 @@ tests:
                   name: codefresh-certs-server
                   secret:
                     secretName: codefresh-certs-server
-                codefresh-dind-config:
-                  name: codefresh-dind-config
+                dind-config:
+                  name: dind-config
                   configMap:
                     name: codefresh-dind-config
             extends:

charts/cf-runtime/tests/runtime/runtime_onprem_test.yaml

@@ -175,8 +175,8 @@ tests:
                   name: codefresh-certs-server
                   mountPath: /etc/ssl/cf
                   readOnly: true
-                codefresh-dind-config:
-                  name: codefresh-dind-config
+                dind-config:
+                  name: dind-config
                   mountPath: /etc/docker/daemon.json
                   subPath: daemon.json
                   readOnly: true
@@ -185,8 +185,8 @@ tests:
                   name: codefresh-certs-server
                   secret:
                     secretName: codefresh-certs-server
-                codefresh-dind-config:
-                  name: codefresh-dind-config
+                dind-config:
+                  name: dind-config
                   configMap:
                     name: codefresh-dind-config
             extends:

charts/cf-runtime/tests/runtime/runtime_test.yaml

@@ -188,8 +188,8 @@ tests:
                   name: codefresh-certs-server
                   mountPath: /etc/ssl/cf
                   readOnly: true
-                codefresh-dind-config:
-                  name: codefresh-dind-config
+                dind-config:
+                  name: dind-config
                   mountPath: /etc/docker/daemon.json
                   subPath: daemon.json
                   readOnly: true
@@ -198,8 +198,8 @@ tests:
                   name: codefresh-certs-server
                   secret:
                     secretName: codefresh-certs-server
-                codefresh-dind-config:
-                  name: codefresh-dind-config
+                dind-config:
+                  name: dind-config
                   configMap:
                     name: codefresh-dind-config
             extends:

charts/cf-runtime/values.yaml

@@ -615,7 +615,7 @@ runtime:
   # @default -- See below
   patch:
     enabled: true
-    name: ""
+    name: "" # e.g. "runtime-patch"
     hook:
       enabled: true
       image:
@@ -654,7 +654,7 @@ runtime:
   # @default -- See below
   gencerts:
     enabled: true
-    name: dind-gencerts
+    name: "" # e.g. "dind-gencerts"
     image:
       registry: quay.io
       repository: codefresh/kubectl