Skip to content

Commit e6ffccb

Browse files
committed
fix(ui): fix author link after identifers structure change
refs: #296
1 parent 6418858 commit e6ffccb

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

web/src/ui/pages/softwareDetails/HeaderDetailCard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ export const HeaderDetailCard = memo((props: Props) => {
136136
author.affiliations?.length <=
137137
0))) && (
138138
<a
139-
href={author.url}
139+
href={author.url ?? author?.identifiers?.[0].url?.toString()}
140140
className={classes.authorLink}
141141
key={author.name}
142142
>

web/src/ui/shared/AuthorCard.tsx

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,18 @@ export function AuthorCard(props: Props) {
8080
</>
8181
);
8282
})}
83-
<div className={classes.externalLinkButtons}>
84-
<LogoURLButton url={author.url} labelFromURL={true} />
85-
</div>
83+
{author.url && (
84+
<div className={classes.externalLinkButtons}>
85+
<LogoURLButton url={author.url} label="Personal website" />
86+
</div>
87+
)}
88+
{author.identifiers?.map(identifier => {
89+
return (
90+
<div className={classes.externalLinkButtons}>
91+
<LogoURLButton url={identifier.url} labelFromURL={true} />
92+
</div>
93+
)
94+
})}
8695
</Card>
8796
);
8897
}

web/src/ui/shared/LogoURLButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ const resolveLogoFromType = (
7474
case "Orcid":
7575
return {
7676
URLlogo: new URL(
77-
"https://homepage-prod.orcid.org/assets/iD_icon_1-9cfee7d6c7.png"
77+
"https://orcid.org/assets/vectors/orcid.logo.icon.svg"
7878
),
7979
textFromURL: "ORCID"
8080
};

0 commit comments

Comments
 (0)