Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirement to prefix env variables with "REACT_APP_" not documented #16

Open
randyxli opened this issue Oct 14, 2022 · 1 comment
Open

Comments

@randyxli
Copy link

It's unclear from the documentation that environment variables must be prefixed with REACT_APP_ for this package to work. I feel this behavior is not desirable in cases where an environment variable should configured on both the frontend and the backend, such as an OAuth client ID. One benefit of only setting variables with that prefix is it avoids the unintentional leaking environment variables, but I think that can be circumvented by defining variables to be distributed in env.js explicitly. Either way, the current prefix requirement should be documented. Happy to submit a PR once its clear that the repo is being maintained.

@sqxieshuai
Copy link

you saved my life!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants