Removed Futuroscope.

Author: dblock

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-10-01 22:20:54 +0300 using RuboCop version 0.50.0.
+# on 2018-01-05 16:54:58 -0500 using RuboCop version 0.50.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -9,23 +9,23 @@
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 110
+  Max: 103
 
-# Offense count: 97
+# Offense count: 94
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
   Max: 142
 
-# Offense count: 4
+# Offense count: 3
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 25
 
 # Offense count: 3
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 398
+  Max: 265
 
 # Offense count: 2
 # Configuration parameters: EnforcedStyle, SupportedStyles.

CHANGELOG.md

@@ -1,5 +1,6 @@
-### 0.8.7 (Next)
+### 0.9.0 (Next)
 
+* [#133](https://github.com/codegram/hyperclient/pull/133): Removed futuroscope - [@dblock](https://github.com/dblock).
 * [#131](https://github.com/codegram/hyperclient/pull/131): Upgrade to Rubocop 0.50.0, fix Bundler's insecure git source warning - [@nebolsin](https://github.com/nebolsin).
 * [#132](https://github.com/codegram/hyperclient/pull/132): Swapped yard dependency for danger-toc - [@dblock](https://github.com/dblock).
 * Your contribution here.

Gemfile

@@ -23,7 +23,6 @@ end
 group :test do
   gem 'danger-changelog', '~> 0.1'
   gem 'danger-toc', '~> 0.1'
-  gem 'futuroscope', github: 'codegram/futuroscope'
   gem 'minitest'
   gem 'mocha'
   gem 'rack-test'

README.md

@@ -18,7 +18,6 @@ Hyperclient is a Hypermedia API client written in Ruby. It fully supports [JSON
   - [Curies](#curies)
   - [Attributes](#attributes)
   - [HTTP](#http)
-  - [Asynchronous requests](#asynchronous-requests)
 - [Testing Using Hyperclient](#testing-using-hyperclient)
 - [Reference](#reference)
 - [Hyperclient Users](#hyperclient-users)
@@ -204,23 +203,6 @@ spline._delete
 
 HTTP methods always return a new instance of Resource.
 
-## Asynchronous requests
-
-By default, Hyperclient requests are performed asynchronously in a background thread pool via the [Futuroscope](https://github.com/codegram/futuroscope) gem. You can control the size of this pool by setting the `min_workers` and `max_workers` settings:
-
-```ruby
-Futuroscope.default_pool.min_workers = 10
-Futuroscope.default_pool.max_workers = 20
-```
-
-If you want to disable this behavior and have all requests performed synchronously, you can use the client `options` to disable this behavior:
-
-```ruby
-api = Hyperclient.new('https://grape-with-roar.herokuapp.com/api') do |client|
-  client.options[:async] = false
-end
-```
-
 # Testing Using Hyperclient
 
 You can combine RSpec, Faraday::Adapter::Rack and Hyperclient to test your HAL API without having to ever examine the raw JSON response.

UPGRADING.md

@@ -1,6 +1,22 @@
 Upgrading Hyperclient
 =====================
 
+### Upgrading to >= 0.9.0
+
+Previous versions of Hyperclient performed asynchronous requests using [futuroscope](https://github.com/codegram/futuroscope) by default, which could be disabled by providing the `:async` option to each Hyperclient instance. This has been removed and you can remove any such code.
+
+```ruby
+api = Hyperclient.new('https://grape-with-roar.herokuapp.com/api') do |client|
+  client.options[:async] = false
+end
+```
+
+The default new behavior is synchronous. We recommend [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby) for your asynchronous needs.
+
+Include [futuroscope](https://github.com/codegram/futuroscope) in your `Gemfile` and wrap Hyperclient requests into `Futuroscope::Future.new` blocks to get the old behavior.
+
+See [#133](https://github.com/codegram/hyperclient/pull/133) and [#123](https://github.com/codegram/hyperclient/issues/123) for more information.
+
 ### Upgrading to >= 0.8.0
 
 ### Changes in curies

hyperclient.gemspec

@@ -15,7 +15,6 @@ Gem::Specification.new do |gem|
   gem.version       = Hyperclient::VERSION
 
   gem.add_dependency 'faraday', '>= 0.9.0'
-  gem.add_dependency 'futuroscope'
   gem.add_dependency 'faraday_middleware'
   gem.add_dependency 'faraday_hal_middleware'
   gem.add_dependency 'uri_template'

lib/hyperclient/entry_point.rb

@@ -38,7 +38,7 @@ class EntryPoint < Link
     def initialize(url, &_block)
       @link = { 'href' => url }
       @entry_point = self
-      @options = { async: true }
+      @options = {}
       @connection = nil
       @resource = nil
       @key = nil
@@ -118,9 +118,7 @@ def faraday_block=(value)
 
     # Public: Read/Set options.
     #
-    # value    - A Hash containing the client options. Use { async: false } to
-    # to disable the default behavior of performing requests asynchronously
-    # using futures.
+    # value    - A Hash containing the client options.
     attr_accessor :options
 
     private

lib/hyperclient/link.rb

@@ -1,5 +1,4 @@
 require 'uri_template'
-require 'futuroscope'
 
 module Hyperclient
   # Internal: The Link is used to let a Resource interact with the API.
@@ -168,15 +167,7 @@ def _uri_template
 
     def http_method(method, body = nil)
       @resource = begin
-        response =
-          if @entry_point.options[:async]
-            Futuroscope::Future.new do
-              @entry_point.connection.run_request(method, _url, body, nil)
-            end
-          else
-            @entry_point.connection.run_request(method, _url, body, nil)
-          end
-
+        response = @entry_point.connection.run_request(method, _url, body, nil)
         Resource.new(response.body, @entry_point, response)
       end
     end

lib/hyperclient/version.rb

@@ -1,3 +1,3 @@
 module Hyperclient
-  VERSION = '0.8.7'.freeze
+  VERSION = '0.9.0'.freeze
 end

test/hyperclient/entry_point_test.rb

@@ -59,12 +59,6 @@ module Hyperclient
           entry_point._url.must_equal 'http://my.api.org'
         end
       end
-
-      describe 'options' do
-        it 'enables the async option by default' do
-          entry_point.options[:async].must_equal true
-        end
-      end
     end
 
     describe 'faraday_options' do