fix: getVersion() for OCI8 and SQLSRV drivers (#9471)

* fix: getVersion() for OCI8 driver when no connection is established

* phpstan - regenerate baseline

* fix: SQLSRV getVersion() when no connection is established

Author: michalsn

system/Database/OCI8/Connection.php

@@ -193,9 +193,14 @@ public function getVersion(): string
             return $this->dataCache['version'];
         }
 
-        if (! $this->connID || ($versionString = oci_server_version($this->connID)) === false) {
+        if ($this->connID === false) {
+            $this->initialize();
+        }
+
+        if (($versionString = oci_server_version($this->connID)) === false) {
             return '';
         }
+
         if (preg_match('#Release\s(\d+(?:\.\d+)+)#', $versionString, $match)) {
             return $this->dataCache['version'] = $match[1];
         }

system/Database/SQLSRV/Connection.php

@@ -561,11 +561,15 @@ public function getVersion(): string
             return $this->dataCache['version'];
         }
 
-        if (! $this->connID || ($info = sqlsrv_server_info($this->connID)) === []) {
+        if (! $this->connID) {
             $this->initialize();
         }
 
-        return isset($info['SQLServerVersion']) ? $this->dataCache['version'] = $info['SQLServerVersion'] : false;
+        if (($info = sqlsrv_server_info($this->connID)) === []) {
+            return '';
+        }
+
+        return isset($info['SQLServerVersion']) ? $this->dataCache['version'] = $info['SQLServerVersion'] : '';
     }
 
     /**

tests/system/Database/Live/GetVersionTest.php

@@ -29,6 +29,12 @@ final class GetVersionTest extends CIUnitTestCase
 
     public function testGetVersion(): void
     {
+        if ($this->db->DBDriver === 'MySQLi') {
+            $this->db->mysqli = false;
+        }
+
+        $this->db->connID = false;
+
         $version = $this->db->getVersion();
 
         $this->assertMatchesRegularExpression('/\A\d+(\.\d+)*\z/', $version);

user_guide_src/source/changelogs/v4.6.1.rst

@@ -33,6 +33,7 @@ Bugs Fixed
 - **CURLRequest:** Fixed an issue where multiple header sections appeared in the CURL response body during multiple redirects from the target server.
 - **Cors:** Fixed a bug in the Cors filter that caused the appropriate headers to not be added when another filter returned a response object in the ``before`` filter.
 - **Database:** Fixed a bug in ``Postgre`` and ``SQLite3`` handlers where composite unique keys were not fully taken into account for ``upsert`` type of queries.
+- **Database:** Fixed a bug in the ``OCI8`` and ``SQLSRV`` drivers where ``getVersion()`` returned an empty string when the database connection was not yet established.
 
 See the repo's
 `CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_

utils/phpstan-baseline/property.notFound.neon

@@ -1,4 +1,4 @@
-# total 58 errors
+# total 59 errors
 
 parameters:
     ignoreErrors:
@@ -42,6 +42,11 @@ parameters:
             count: 2
             path: ../../tests/system/Database/BaseConnectionTest.php
 
+        -
+            message: '#^Access to an undefined property CodeIgniter\\Database\\BaseConnection\:\:\$mysqli\.$#'
+            count: 1
+            path: ../../tests/system/Database/Live/GetVersionTest.php
+
         -
             message: '#^Access to an undefined property CodeIgniter\\Database\\BaseConnection\:\:\$foundRows\.$#'
             count: 2