Skip to content

Commit 288c05f

Browse files
committed
refactor: review github CI on PHP8.4
1 parent fff0c87 commit 288c05f

File tree

4 files changed

+6
-14
lines changed

4 files changed

+6
-14
lines changed

.github/workflows/reusable-phpunit-test.yml

-1
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,6 @@ jobs:
203203
DB: ${{ inputs.db-platform }}
204204
TACHYCARDIA_MONITOR_GA: ${{ inputs.enable-profiling && 'enabled' || '' }}
205205
TERM: xterm-256color
206-
continue-on-error: ${{ inputs.php-version == '8.4' }}
207206

208207
- name: Upload coverage results as artifact
209208
if: ${{ inputs.enable-artifact-upload }}

.github/workflows/test-coding-standards.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
matrix:
3030
php-version:
3131
- '8.1'
32-
- '8.3'
32+
- '8.4'
3333

3434
steps:
3535
- name: Checkout

.github/workflows/test-phpunit.yml

+4-11
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,7 @@ jobs:
5959
- '8.1'
6060
- '8.2'
6161
- '8.3'
62-
include:
63-
- php-version: '8.4'
64-
composer-option: '--ignore-platform-req=php'
62+
- '8.4'
6563

6664
uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
6765
with:
@@ -88,6 +86,7 @@ jobs:
8886
- '8.1'
8987
- '8.2'
9088
- '8.3'
89+
- '8.4'
9190
db-platform:
9291
- MySQLi
9392
- OCI8
@@ -100,8 +99,6 @@ jobs:
10099
- php-version: '8.1'
101100
db-platform: MySQLi
102101
mysql-version: '5.7'
103-
- php-version: '8.4'
104-
composer-option: '--ignore-platform-req=php'
105102

106103
uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
107104
with:
@@ -129,9 +126,7 @@ jobs:
129126
- '8.1'
130127
- '8.2'
131128
- '8.3'
132-
include:
133-
- php-version: '8.4'
134-
composer-option: '--ignore-platform-req=php'
129+
- '8.4'
135130

136131
uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
137132
with:
@@ -157,9 +152,7 @@ jobs:
157152
- '8.1'
158153
- '8.2'
159154
- '8.3'
160-
include:
161-
- php-version: '8.4'
162-
composer-option: '--ignore-platform-req=php'
155+
- '8.4'
163156

164157
uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
165158
with:

.github/workflows/test-rector.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
strategy:
4646
fail-fast: false
4747
matrix:
48-
php-versions: ['8.1', '8.3']
48+
php-versions: ['8.1', '8.4']
4949
steps:
5050
- name: Checkout
5151
uses: actions/checkout@v4

0 commit comments

Comments
 (0)