Skip to content

Commit 312ffa0

Browse files
committed
chore: move continue-on-error to reusable-phpunit-test.yml
1 parent 296c5a5 commit 312ffa0

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

.github/workflows/reusable-phpunit-test.yml

+1
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ jobs:
203203
DB: ${{ inputs.db-platform }}
204204
TACHYCARDIA_MONITOR_GA: ${{ inputs.enable-profiling && 'enabled' || '' }}
205205
TERM: xterm-256color
206+
continue-on-error: ${{ inputs.php-version == '8.4' }}
206207

207208
- name: Upload coverage results as artifact
208209
if: ${{ inputs.enable-artifact-upload }}

.github/workflows/test-phpunit.yml

-4
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ jobs:
6262
include:
6363
- php-version: '8.4'
6464
composer-option: '--ignore-platform-req=php'
65-
continue-on-error: true
6665

6766
uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
6867
with:
@@ -103,7 +102,6 @@ jobs:
103102
mysql-version: '5.7'
104103
- php-version: '8.4'
105104
composer-option: '--ignore-platform-req=php'
106-
continue-on-error: true
107105

108106
uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
109107
with:
@@ -134,7 +132,6 @@ jobs:
134132
include:
135133
- php-version: '8.4'
136134
composer-option: '--ignore-platform-req=php'
137-
continue-on-error: true
138135

139136
uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
140137
with:
@@ -163,7 +160,6 @@ jobs:
163160
include:
164161
- php-version: '8.4'
165162
composer-option: '--ignore-platform-req=php'
166-
continue-on-error: true
167163

168164
uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
169165
with:

0 commit comments

Comments
 (0)