Skip to content

Commit 4558547

Browse files
committed
simplify tests
1 parent 1d07e9f commit 4558547

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

tests/system/Images/ImageMagickHandlerTest.php

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ public function testClearMetadataAll(): void
465465
/** @var Imagick $imagick */
466466
$imagick = $this->handler->getResource();
467467
$before = $imagick->getImageProperties();
468-
$this->assertCount(14, $before);
468+
$this->assertGreaterThan(10, $before);
469469

470470
$this->handler
471471
->clearMetadata()
@@ -476,7 +476,7 @@ public function testClearMetadataAll(): void
476476
$imagick = $this->handler->getResource();
477477
$after = $imagick->getImageProperties();
478478

479-
$this->assertCount(9, $after);
479+
$this->assertLessThan(10, count($after));
480480
}
481481

482482
public function testClearMetadataExcept(): void
@@ -485,7 +485,7 @@ public function testClearMetadataExcept(): void
485485
/** @var Imagick $imagick */
486486
$imagick = $this->handler->getResource();
487487
$before = $imagick->getImageProperties();
488-
$this->assertCount(14, $before);
488+
$this->assertArrayHasKey('png:gAMA', $before);
489489

490490
// Keep 2 properties
491491
$this->handler
@@ -500,8 +500,6 @@ public function testClearMetadataExcept(): void
500500
$this->assertArrayHasKey('png:bKGD', $after);
501501
$this->assertArrayHasKey('png:cHRM', $after);
502502
$this->assertArrayNotHasKey('png:gAMA', $after);
503-
504-
$this->assertCount(12, $after);
505503
}
506504

507505
public function testClearMetadataSpecific(): void
@@ -511,8 +509,9 @@ public function testClearMetadataSpecific(): void
511509
$imagick = $this->handler->getResource();
512510
$before = $imagick->getImageProperties();
513511

514-
$this->assertArrayNotHasKey('png:tIME', $before);
515-
$this->assertCount(14, $before);
512+
$this->assertArrayHasKey('png:bKGD', $before);
513+
$this->assertArrayHasKey('png:cHRM', $before);
514+
$this->assertArrayHasKey('png:gAMA', $before);
516515

517516
// Delete only 1
518517
$this->handler
@@ -526,9 +525,6 @@ public function testClearMetadataSpecific(): void
526525

527526
$this->assertArrayHasKey('png:bKGD', $after);
528527
$this->assertArrayHasKey('png:cHRM', $after);
529-
$this->assertArrayHasKey('png:tIME', $after);
530528
$this->assertArrayNotHasKey('png:gAMA', $after);
531-
532-
$this->assertCount(14, $after);
533529
}
534530
}

0 commit comments

Comments
 (0)