fix: Apply suggestion

Author: neznaika0

system/HTTP/Parameters/InputParameters.php

@@ -18,7 +18,9 @@
 
 /**
  * @template TKey of string
- * @template TValue of bool|float|int|string|array<int|string, mixed>
+ * @template TValue of scalar|array<(int|string), mixed>
+ *
+ * @extends Parameters<TKey, TValue>
  *
  * @see \CodeIgniter\HTTP\Parameters\InputParametersTest
  */
@@ -33,7 +35,7 @@ public function override(array $parameters = []): void
         }
     }
 
-    public function get(string $key, $default = null)
+    public function get(string $key, mixed $default = null): mixed
     {
         if ($default !== null && ! is_scalar($default)) {
             throw new InvalidArgumentException(sprintf('The default value for the InputParameters must be a scalar type, "%s" given.', gettype($default)));
@@ -51,7 +53,7 @@ public function get(string $key, $default = null)
         return $value === $tempDefault ? $default : $value;
     }
 
-    public function set(string $key, $value): void
+    public function set(string $key, mixed $value): void
     {
         if (! is_scalar($value) && ! is_array($value)) {
             throw new InvalidArgumentException(sprintf('The value for the InputParameters must be a scalar type, "%s" given.', gettype($value)));

system/HTTP/Parameters/Parameters.php

@@ -18,14 +18,17 @@
 
 /**
  * @template TKey of string
- * @template TValue of mixed
+ * @template TValue
  *
- * @property array<TKey, TValue> $parameters
+ * @implements ParametersInterface<TKey, TValue>
  *
  * @see \CodeIgniter\HTTP\Parameters\ParametersTest
  */
 class Parameters implements ParametersInterface
 {
+    /**
+     * @param array<TKey, TValue> $parameters
+     */
     public function __construct(
         protected array $parameters = [],
     ) {
@@ -41,12 +44,12 @@ public function has(string $key): bool
         return array_key_exists($key, $this->parameters);
     }
 
-    public function get(string $key, $default = null)
+    public function get(string $key, mixed $default = null): mixed
     {
         return array_key_exists($key, $this->parameters) ? $this->parameters[$key] : $default;
     }
 
-    public function set(string $key, $value): void
+    public function set(string $key, mixed $value): void
     {
         $this->parameters[$key] = $value;
     }

system/HTTP/Parameters/ParametersInterface.php

@@ -18,7 +18,9 @@
 
 /**
  * @template TKey of string
- * @template TValue of mixed
+ * @template TValue
+ *
+ * @extends IteratorAggregate<TKey, TValue>
  */
 interface ParametersInterface extends IteratorAggregate, Countable
 {
@@ -41,15 +43,15 @@ public function has(string $key): bool;
      * @param TKey   $key
      * @param TValue $default
      *
-     * @return ?TValue
+     * @return TValue|null
      */
-    public function get(string $key, $default = null);
+    public function get(string $key, mixed $default = null): mixed;
 
     /**
      * @param TKey   $key
      * @param TValue $value
      */
-    public function set(string $key, $value): void;
+    public function set(string $key, mixed $value): void;
 
     /**
      * @param TKey $key
@@ -59,7 +61,7 @@ public function set(string $key, $value): void;
     public function all(?string $key = null): array;
 
     /**
-     * @return array<int, TKey>
+     * @return list<TKey>
      */
     public function keys(): array;
 }

system/HTTP/Parameters/ServerParameters.php

@@ -13,6 +13,12 @@
 
 namespace CodeIgniter\HTTP\Parameters;
 
+/**
+ * @template TKey of string
+ * @template TValue
+ *
+ * @extends Parameters<TKey, TValue>
+ */
 class ServerParameters extends Parameters
 {
 }

tests/system/HTTP/Parameters/InputParametersTest.php

@@ -52,7 +52,7 @@ public function testGetNonScalarValues(): void
 
         $this->expectException(InvalidArgumentException::class);
 
-        $parameters->get('undefined_throw', new stdClass());
+        $parameters->get('undefined_throw', new stdClass()); // @phpstan-ignore argument.type
     }
 
     public function testAttemptSetNullValues(): void
@@ -61,7 +61,7 @@ public function testAttemptSetNullValues(): void
 
         $this->expectException(InvalidArgumentException::class);
 
-        $parameters->set('nullable', null);
+        $parameters->set('nullable', null); // @phpstan-ignore argument.type
     }
 
     public function testAttemptSetNonScalarValues(): void
@@ -70,7 +70,7 @@ public function testAttemptSetNonScalarValues(): void
 
         $this->expectException(InvalidArgumentException::class);
 
-        $parameters->set('nullable', null);
+        $parameters->set('nullable', new stdClass()); // @phpstan-ignore argument.type
     }
 
     public function testUpdateAndSetNewValues(): void