refactor: Fix phpstan always true (#9367)

neznaika0 · web-flow · commit 708fb6d70a72 · 2025-01-10T11:29:32.000+08:00
diff --git a/system/Helpers/filesystem_helper.php b/system/Helpers/filesystem_helper.php
@@ -96,7 +96,7 @@ function directory_mirror(string $originDir, string $targetDir, bool $overwrite
                 if (! is_dir($target)) {
                     mkdir($target, 0755);
                 }
-            } elseif (! is_file($target) || ($overwrite && is_file($target))) {
+            } elseif ($overwrite || ! is_file($target)) {
                 copy($origin, $target);
             }
         }
diff --git a/utils/phpstan-baseline/booleanAnd.rightAlwaysTrue.neon b/utils/phpstan-baseline/booleanAnd.rightAlwaysTrue.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -1,7 +1,6 @@
 includes:
     - argument.type.neon
     - assign.propertyType.neon
-    - booleanAnd.rightAlwaysTrue.neon
     - codeigniter.cacheHandlerInstance.neon
     - codeigniter.configArgumentInstanceof.neon
     - codeigniter.frameworkExceptionInstance.neon

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ function directory_mirror(string $originDir, string $targetDir, bool $overwrite`
`96`	`96`	`if (! is_dir($target)) {`
`97`	`97`	`mkdir($target, 0755);`
`98`	`98`	`}`
`99`		`- } elseif (! is_file($target) \|\| ($overwrite && is_file($target))) {`
	`99`	`+ } elseif ($overwrite \|\| ! is_file($target)) {`
`100`	`100`	`copy($origin, $target);`
`101`	`101`	`}`
`102`	`102`	`}`